Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported release failure for cloud.google.com/go/storage #940

Closed
tritone opened this issue Jun 29, 2021 · 3 comments
Closed

Reported release failure for cloud.google.com/go/storage #940

tritone opened this issue Jun 29, 2021 · 3 comments
Assignees
Labels
external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tritone
Copy link

tritone commented Jun 29, 2021

I released cloud.google.com/go/storage v1.16.0 yesterday by merging googleapis/google-cloud-go#4332 . I then got an email with a link to the following build, indicating that the release had failed: https://github.com/googleapis/google-cloud-go/actions/runs/980149026

The tag creation appears to have succeeded, and the release is visible on github and pkg.go.dev. I'm wondering if there is anything else that I need to do in response to this failure?

@codyoss codyoss added the triage me I really want to be triaged. label Jun 30, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Jun 30, 2021
@chingor13
Copy link
Contributor

Your repo has 2 types of releases:

  1. submodule release (individual releases for special services like storage)
  2. meta-package release (all of the packages)

The release in question was a release PR for (1), but the failure was for the meta-package release. release-please is trying to tag v1.16.0 of the meta-package which is incorrect. This is not a use-case that the release-please-action was expecting to validate (2 separate types of releases).

To fix, I would add if conditions to your workflows to ensure it's only running against the correct types of releases.

@chingor13 chingor13 added the external This issue is blocked on a bug with the actual product. label Jul 1, 2021
@tritone
Copy link
Author

tritone commented Jul 7, 2021

@chingor13 thanks for clarifying!

@codyoss I think you own these workflows for google-cloud-go, would you be able to fix this?

@codyoss codyoss self-assigned this Jul 7, 2021
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 7, 2021
@chingor13 chingor13 removed their assignment Jul 7, 2021
@codyoss
Copy link
Member

codyoss commented Sep 21, 2021

I believe this was fixed a while back with googleapis/google-cloud-go#4537. We now do have some failures due to quota, but that is a different issue, so closing this for now.

@codyoss codyoss closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants