Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce detect-checked command, a quick check for whether a release has been requested #93

Merged
merged 4 commits into from
May 16, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 15, 2019

breaking candidate-issue into two commands:

candidate-issue and detect-checked-issue;

This will allow us to run the less expensive (in terms of API calls) checkbox check more frequently as a cron, and the expensive candidate-issue which updates a candidate issue less frequently.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #93 into master will decrease coverage by 0.81%.
The diff coverage is 19.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   47.18%   46.36%   -0.82%     
==========================================
  Files           9        9              
  Lines        1153     1182      +29     
  Branches       31       31              
==========================================
+ Hits          544      548       +4     
- Misses        607      632      +25     
  Partials        2        2
Impacted Files Coverage Δ
src/candidate-issue.ts 36.5% <16.21%> (-4.2%) ⬇️
src/github.ts 22.68% <23.07%> (ø) ⬆️
src/release-pr.ts 37.71% <50%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4cd4f...638da3b. Read the comment docs.

@bcoe bcoe changed the title [WIP] feat: breaking candidate-issue into two commands feat: breaking candidate-issue into two commands May 16, 2019
@bcoe bcoe changed the title feat: breaking candidate-issue into two commands feat: introduce detect-checked command, a quick check for whether a release has been requested May 16, 2019
@bcoe bcoe merged commit d835335 into master May 16, 2019
@bcoe bcoe deleted the perf-improvements branch May 16, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants