Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Node 10 is required for async/await #89

Merged
merged 2 commits into from
May 15, 2019
Merged

fix: Node 10 is required for async/await #89

merged 2 commits into from
May 15, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 15, 2019

fixes: #14

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   47.31%   47.27%   -0.05%     
==========================================
  Files           9        9              
  Lines        1154     1155       +1     
  Branches       31       31              
==========================================
  Hits          546      546              
- Misses        606      607       +1     
  Partials        2        2
Impacted Files Coverage Δ
src/candidate-issue.ts 41.37% <33.33%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1bc9b...740e1ba. Read the comment docs.

@bcoe bcoe merged commit c795eef into master May 15, 2019
@bcoe bcoe deleted the correct-engines branch May 15, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not work on Node.js v8.16.0
2 participants