Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ocaml): Improve OCaml releaser for monorepos #867

Merged
merged 3 commits into from Apr 19, 2021

Conversation

phated
Copy link
Contributor

@phated phated commented Apr 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #864
Closes #865
Closes #866 馃

@phated phated requested a review from a team April 19, 2021 01:47
@phated phated requested a review from a team as a code owner April 19, 2021 01:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2021
@phated
Copy link
Contributor Author

phated commented Apr 19, 2021

I have a patch for #866 but the tests are failing for some snapshot thing so I'll figure that out before including. Added here.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #867 (5e8028b) into master (da15626) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   94.27%   94.29%   +0.02%     
==========================================
  Files          68       69       +1     
  Lines        9600     9638      +38     
  Branches      982     1040      +58     
==========================================
+ Hits         9050     9088      +38     
  Misses        547      547              
  Partials        3        3              
Impacted Files Coverage 螖
src/releasers/ocaml.ts 100.00% <100.00%> (酶)
src/updaters/ocaml/dune-project.ts 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update da15626...5e8028b. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated thanks for fixing this up 馃憤

@bcoe bcoe merged commit 81422dc into googleapis:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
2 participants