Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow "standard" pre-1.0.0 patch bumps #847

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Conversation

joeldodge79
Copy link
Collaborator

@joeldodge79 joeldodge79 commented Mar 31, 2021

opt-in behavior for pre-1.0.0 packages that want to follow the standard
conventional commits behavior of bumping the patch instead of the minor

the motivation for this change is compatibility for node package dependencies with versions < 1.0.0 using Caret Ranges

@joeldodge79 joeldodge79 requested review from bcoe and a team March 31, 2021 13:32
@joeldodge79 joeldodge79 requested a review from a team as a code owner March 31, 2021 13:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2021
@joeldodge79 joeldodge79 reopened this Apr 1, 2021
opt-in behavior for packages that want to follow the standard
convetional-commits behavior of bumping the patch instead of the minor
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #847 (f87de53) into master (2799647) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   93.75%   93.77%   +0.01%     
==========================================
  Files          64       64              
  Lines        9181     9203      +22     
  Branches      933      988      +55     
==========================================
+ Hits         8608     8630      +22     
  Misses        570      570              
  Partials        3        3              
Impacted Files Coverage Δ
src/bin/release-please.ts 93.07% <100.00%> (+0.17%) ⬆️
src/conventional-commits.ts 99.20% <100.00%> (+0.01%) ⬆️
src/index.ts 100.00% <100.00%> (ø)
src/manifest.ts 100.00% <100.00%> (ø)
src/release-pr.ts 94.49% <100.00%> (+0.02%) ⬆️
src/releasers/node.ts 100.00% <100.00%> (ø)
src/releasers/python.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2799647...f87de53. Read the comment docs.

@bcoe bcoe removed the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
@bcoe bcoe merged commit a5e2cc2 into master Apr 7, 2021
@bcoe bcoe deleted the pre-major-feat-bump-patch branch April 7, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants