Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update templated tf versions #812

Merged
merged 3 commits into from Mar 9, 2021
Merged

fix: update templated tf versions #812

merged 3 commits into from Mar 9, 2021

Conversation

bharathkkb
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #811 馃

@bharathkkb bharathkkb requested a review from a team as a code owner March 8, 2021 20:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #812 (d5f3a10) into master (4a9345b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   93.56%   93.57%           
=======================================
  Files          64       64           
  Lines        8880     8885    +5     
  Branches      931      933    +2     
=======================================
+ Hits         8309     8314    +5     
  Misses        568      568           
  Partials        3        3           
Impacted Files Coverage 螖
src/releasers/terraform-module.ts 92.12% <100.00%> (+0.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4a9345b...d5f3a10. Read the comment docs.

@bcoe bcoe merged commit d222746 into googleapis:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templated terraform versions.tf are not being updated
2 participants