Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checkbox based releases #77

Merged
merged 2 commits into from May 10, 2019
Merged

feat: checkbox based releases #77

merged 2 commits into from May 10, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 10, 2019

based on @alexander-fenster's recommendation I've simplified the design significantly; to create a release you now just click on a checkbox:

Screen Shot 2019-05-09 at 11 33 45 PM

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2019
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files           5        5           
  Lines         330      330           
  Branches       26       26           
=======================================
  Hits          272      272           
  Misses         56       56           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdab21...7eb03b1. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

One question - what happens when I don't have access to cut a release?

@bcoe
Copy link
Contributor Author

bcoe commented May 10, 2019

@JustinBeckwith, @alexander-fenster and my working theory was that you would need edit access to issues on the repo to check the box (which should mean it's appropriate for you to create a release).

I will confirm this as soon as we release.

@bcoe bcoe merged commit 1e4193c into master May 10, 2019
@bcoe bcoe deleted the checkbox-based branch May 10, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants