Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check multiple pages of merged PRs for release PR #699

Closed
bcoe opened this issue Jan 12, 2021 · 3 comments
Closed

Check multiple pages of merged PRs for release PR #699

bcoe opened this issue Jan 12, 2021 · 3 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bcoe
Copy link
Contributor

bcoe commented Jan 12, 2021

With the current approach to finding release PRs, we grab a single page of merged release PRs and look through it for release PRs.

This just caused an issue for @codyoss, because our page size was 25, and there were more than 25 PRs that had been newer than the prior release.

In the context of creating a GitHub release, we should look for a few pages of release PRs.

@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 12, 2021
@joeldodge79
Copy link
Collaborator

I read this and thought for a minute:

"wow, >25 PRs landed between merging the Release PR and the release-please-action receiving the push event and searching for merged Release PRs?"

Then I realized this is probably related to using the release-please cli, right? I add this comment mostly as a way to confirm my new-to-release-please{-action} understanding of the world.

@bcoe
Copy link
Contributor Author

bcoe commented Jan 14, 2021

@joeldodge79 I think once merged PRs are the order of created, so the problem was a monorepo where one package hadn't been released in quite a while, but others had been.

@chingor13 chingor13 self-assigned this Feb 4, 2021
@chingor13
Copy link
Contributor

This was fixed in #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants