Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-release): increase page size finding release #698

Merged
merged 1 commit into from Jan 12, 2021
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 12, 2021

In monorepos there's enough traffic on PRs that looking at the last 25 didn't catch a release.

@bcoe bcoe requested a review from a team as a code owner January 12, 2021 00:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #698 (ac46468) into master (0d63813) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files          49       49           
  Lines        5972     5972           
  Branches      565      565           
=======================================
  Hits         5103     5103           
  Misses        868      868           
  Partials        1        1           
Impacted Files Coverage Δ
src/github-release.ts 96.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d63813...ac46468. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use search with pagination.

@bcoe bcoe merged commit c156950 into master Jan 12, 2021
@bcoe bcoe deleted the page-size branch January 12, 2021 01:00
@bcoe bcoe changed the title fix(github-release): increasae page size finding release fix(github-release): increase page size finding release Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants