Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-release node monorepo package: no recent release PRs found #668

Closed
joeldodge79 opened this issue Dec 16, 2020 · 0 comments · Fixed by #669
Closed

github-release node monorepo package: no recent release PRs found #668

joeldodge79 opened this issue Dec 16, 2020 · 0 comments · Fixed by #669
Assignees
@yoshi-automation
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@joeldodge79
Copy link
Collaborator

Using the release-please-action a release pr is created and appropriately updated. However, once it's merged the workflow logs no recent release PRs found

config:

         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           release-type: node
           monorepo-tags: true
           # tried with and w/out package-name
           # package-name: '@looker/sdk'
           path: packages/sdk/
@joeldodge79 joeldodge79 mentioned this issue Dec 16, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 17, 2020
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 18, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Dec 18, 2020
@erezrokah erezrokah mentioned this issue Jan 3, 2021
Closed
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 9, 2021
@joeldodge79
fix(monorepos): github-release not created (#669)
9f69f41 
fixes a couple of issues:
1. if node releaser doesn't specify packageName then github-release
wasn't filtering merged PRs correctly.
2. when solving the above, we need to be consistent about the
relationship between packageName and the release branch name.


Fixes #668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@bcoe @joeldodge79 @yoshi-automation