Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add commits of type docs to the changelog #459

Closed
busunkim96 opened this issue Jun 11, 2020 · 8 comments
Closed

Python: Add commits of type docs to the changelog #459

busunkim96 opened this issue Jun 11, 2020 · 8 comments
Assignees
@busunkim96
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

See googleapis/python-pubsub#117 (comment)

Also clarify that it is normal to not see all the commits listed in the release notes. (This has been a point of confusion a few times in the Python repositories).

CC @plamut
@busunkim96 busunkim96 mentioned this issue Jun 11, 2020
Merged
4 tasks
@bcoe
Copy link
Contributor

bcoe commented Jun 11, 2020

@busunkim96 👋 this can be configured. I think we can use the same approach we used for Ruby for Python:

https://github.com/googleapis/release-please/blob/master/src/releasers/ruby-yoshi.ts#L29

@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 11, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 11, 2020
@busunkim96
fix: list commits of type docs for python (#460)
ba06649 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] #459 
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@jcornaz
Copy link

jcornaz commented Jul 31, 2020

this can be configured.

Great!

How do we configure it? Can you point to some documentation please?

@busunkim96
Copy link
Contributor Author

@jcornaz The PR shows an example of this

@busunkim96
Copy link
Contributor Author

Closing as the original issue is resolved.

@jcornaz
Copy link

jcornaz commented Jul 31, 2020

@jcornaz The PR shows an example of this

I don't understand. That's a code change in this repository.

Does it mean that the only way to "configure" is to actually fork this repository and change the code?

Nevertheless as this issue is closed should I open a new issue for adding the documentation?

@busunkim96
Copy link
Contributor Author

@jcornaz 👍 I think opening a new issue with your question would be best.

@jcornaz jcornaz mentioned this issue Jul 31, 2020
Closed
@jcornaz
Copy link

jcornaz commented Jul 31, 2020

@busunkim96 I created #511

@tswast
Copy link

tswast commented Dec 1, 2021

Has this been reverted by #1104 (review)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bcoe @tswast @jcornaz @busunkim96