fix: don't include pre-release in latestTag calculation #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
May 5, 2020
| @@ -836,8 +836,8 @@ This PR was generated with [Release Please](https://github.com/googleapis/releas | |||
| ` | |||
|
|
|||
| exports['labels-bom'] = { | |||
| "labels": [ | |||
There was a problem hiding this comment.
Possible you need to ignore __snapshots__ in your .prettierignore
chingor13
approved these changes
May 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 89.35% 89.36%
=======================================
Files 30 30
Lines 3494 3497 +3
Branches 333 334 +1
=======================================
+ Hits 3122 3125 +3
Misses 371 371
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-releases were being used in the logic for calculating the latest tag, this meant that as soon as we released a pre-release, it broke the CHANGELOG generation on the next run.