Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapshots will now be taken from the latest commit #400

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 8, 2020

snapshot releases were pinning at ancient SHAs in some cases, because we use the last tag rather than the latest commit at head.

We now use the latest commit at head.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #400 into master will decrease coverage by 1.77%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   89.08%   87.31%   -1.78%     
==========================================
  Files          27       27              
  Lines        3170     3176       +6     
  Branches      296      240      -56     
==========================================
- Hits         2824     2773      -51     
- Misses        346      400      +54     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/releasers/java-yoshi.ts 91.13% <88.88%> (-2.02%) ⬇️
src/release-pr.ts 85.77% <0.00%> (-4.35%) ⬇️
src/github.ts 72.37% <0.00%> (-2.82%) ⬇️
src/github-release.ts 95.20% <0.00%> (-2.40%) ⬇️
src/releasers/php-yoshi.ts 91.01% <0.00%> (-2.35%) ⬇️
src/graphql-to-commits.ts 88.46% <0.00%> (-1.65%) ⬇️
src/conventional-commits.ts 97.27% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2c74e...f875b82. Read the comment docs.

@bcoe bcoe merged commit 274f852 into master Apr 8, 2020
@bcoe bcoe deleted the fix-snapshot-head branch April 8, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants