Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle multiline bulleted commit messages #396

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 4, 2020

handles multi-line bulleted commit messages.

fixes: #287

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2020
@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #396 into master will increase coverage by 4.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #396     +/-   ##
=========================================
+ Coverage   83.03%   87.53%   +4.5%     
=========================================
  Files          13       27     +14     
  Lines        2305     3170    +865     
  Branches      210      240     +30     
=========================================
+ Hits         1914     2775    +861     
- Misses        391      392      +1     
- Partials        0        3      +3
Impacted Files Coverage Δ
src/util/indent-commit.ts 100% <100%> (ø)
src/release-pr.ts 85.77% <0%> (-4.35%) ⬇️
src/github-release.ts 95.2% <0%> (-2.4%) ⬇️
src/releasers/php-yoshi.ts 91.01% <0%> (-2.35%) ⬇️
src/graphql-to-commits.ts 88.46% <0%> (-1.65%) ⬇️
src/conventional-commits.ts 97.27% <0%> (-0.46%) ⬇️
src/updaters/java/pom-xml.ts 100% <0%> (ø)
src/updaters/java/versions-manifest.ts 100% <0%> (ø)
src/updaters/java/java_update.ts 96.15% <0%> (ø)
src/updaters/terraform/readme.ts 100% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cf69b...1311ae4. Read the comment docs.

@bcoe bcoe merged commit 670d872 into master Apr 4, 2020
@bcoe bcoe deleted the multiline-bulleted branch April 4, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-line bullet points in comment body are being ignored.
3 participants