Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the sleep logic actually work #395

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix: make the sleep logic actually work #395

merged 1 commit into from
Apr 8, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 4, 2020

there was a bug with the delay logic for snapshots.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2020
@bcoe bcoe requested a review from chingor13 April 4, 2020 00:07
@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #395 into master will decrease coverage by 1.95%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   89.27%   87.31%   -1.96%     
==========================================
  Files          27       27              
  Lines        3170     3170              
  Branches      297      239      -58     
==========================================
- Hits         2830     2768      -62     
- Misses        340      399      +59     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/releasers/java-yoshi.ts 91.27% <0.00%> (-3.74%) ⬇️
src/release-pr.ts 85.77% <0.00%> (-4.35%) ⬇️
src/github.ts 72.37% <0.00%> (-2.82%) ⬇️
src/github-release.ts 95.20% <0.00%> (-2.40%) ⬇️
src/releasers/php-yoshi.ts 91.01% <0.00%> (-2.35%) ⬇️
src/graphql-to-commits.ts 88.46% <0.00%> (-1.65%) ⬇️
src/conventional-commits.ts 97.27% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c5966...77c0d3e. Read the comment docs.

@bcoe bcoe merged commit 0e2c74e into master Apr 8, 2020
@bcoe bcoe deleted the fix-sleep branch April 8, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants