Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue using latestTag.sha as base; make delay actually work #394

Merged
merged 1 commit into from Apr 3, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 3, 2020

No description provided.

@bcoe bcoe requested a review from chingor13 April 3, 2020 22:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #394 into master will increase coverage by 1.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   79.38%   80.91%   +1.52%     
==========================================
  Files          13       13              
  Lines        2324     2305      -19     
  Branches      197      167      -30     
==========================================
+ Hits         1845     1865      +20     
+ Misses        472      439      -33     
+ Partials        7        1       -6     
Impacted Files Coverage Δ
src/release-pr.ts 85.77% <ø> (+4.15%) ⬆️
src/github-release.ts 95.20% <0.00%> (-0.80%) ⬇️
src/releasers/php-yoshi.ts 91.01% <0.00%> (+0.78%) ⬆️
src/github.ts 65.54% <0.00%> (+1.62%) ⬆️
src/graphql-to-commits.ts 88.46% <0.00%> (+1.64%) ⬆️
src/conventional-commits.ts 97.27% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56ea70...d1d939c. Read the comment docs.

@bcoe bcoe merged commit 9e9acb0 into master Apr 3, 2020
@bcoe bcoe deleted the fix-delay branch April 3, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants