Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace all version update tags #260

Merged
merged 2 commits into from Sep 11, 2019
Merged

fix: replace all version update tags #260

merged 2 commits into from Sep 11, 2019

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Sep 10, 2019 •
edited

Fixes #261

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2019
@codecov
Copy link

codecov bot commented Sep 10, 2019 •
edited

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          21       21           
  Lines        2590     2590           
  Branches      194      194           
=======================================
  Hits         2014     2014           
  Misses        564      564           
  Partials       12       12
Impacted Files Coverage Δ
src/updaters/java/pom-xml.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254597f...f904d82. Read the comment docs.

bcoe
bcoe approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit might be worth adding a test for, if there's a specific edge-case that bit you.

@chingor13
Copy link
Contributor Author

@bcoe Added a test

@bcoe bcoe merged commit 54e0cd3 into googleapis:master Sep 11, 2019
@chingor13 chingor13 deleted the patch-1 branch September 11, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java: doesn't replace all versions in the pom files
3 participants
@chingor13 @bcoe @googlebot