Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting default initial version per language #251

Merged
merged 2 commits into from Aug 27, 2019

Conversation

chingor13
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.04%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage    77.8%   77.76%   -0.05%     
==========================================
  Files          21       21              
  Lines        2586     2590       +4     
  Branches      194      194              
==========================================
+ Hits         2012     2014       +2     
- Misses        562      564       +2     
  Partials       12       12
Impacted Files Coverage Δ
src/release-pr.ts 82.27% <40%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5886f...df65e5a. Read the comment docs.

@@ -155,4 +155,8 @@ export class JavaYoshi extends ReleasePR {
candidate.version
);
}

protected defaultInitialVersion(): string {
return '0.1.0';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach.

@bcoe bcoe merged commit d8fff67 into googleapis:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants