fix: address a couple more bugs with Ruby libraries #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
we might actually want to fix grafeas client's naming in the ruby mono repo. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 77.76% 77.76%
=======================================
Files 21 21
Lines 2590 2590
Branches 194 194
=======================================
Hits 2014 2014
Misses 564 564
Partials 12 12
Continue to review full report at Codecov.
|
chingor13
approved these changes
Aug 23, 2019
AVaksman
approved these changes
Aug 27, 2019
| @@ -123,7 +123,7 @@ export class ReleasePR { | |||
| if (pr.number !== currentPRNumber) { | |||
| // on mono repos that maintain multiple open release PRs, we use the | |||
| // pull request title to differentiate between PRs: | |||
| if (includePackageName && !pr.title.includes(this.packageName)) { | |||
| if (includePackageName && !pr.title.includes(` ${this.packageName} `)) { | |||
There was a problem hiding this comment.
Interesting, why do we need the spaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/grafeasnotlib/grafeas-client, we should be mindful of any other libraries that are edge cases.