Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address bugs found during first run on Ruby #238

Merged
merged 5 commits into from Aug 22, 2019
Merged

fix: address bugs found during first run on Ruby #238

merged 5 commits into from Aug 22, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 22, 2019

  1. we now check the last 100 PRs, when deciding whether to close stale PRs.
  2. we now show a "Documentation" section in changelog: only with one entry for all docs, only if at least one docs change exists.
  3. our logic for updating version.rb was slightly off (it needed to replace - with /).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #238 into master will increase coverage by 0.06%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   77.73%   77.79%   +0.06%     
==========================================
  Files          21       21              
  Lines        2565     2581      +16     
  Branches      192      193       +1     
==========================================
+ Hits         1994     2008      +14     
- Misses        559      561       +2     
  Partials       12       12
Impacted Files Coverage Δ
src/github.ts 56.11% <100%> (ø) ⬆️
src/conventional-commits.ts 93.51% <88.23%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d1fb5...e175e99. Read the comment docs.

@bcoe bcoe merged commit 9ffe1c7 into master Aug 22, 2019
@bcoe bcoe deleted the below-fold branch August 22, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants