Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for google-auth-library-java #203

Merged
merged 8 commits into from Jul 26, 2019
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 17, 2019

Adds support for the files that should be updated during a release of google-auth-library-java (this represents a good prototype of what things will look like once the repo split happens for Java).

New updaters added:

  • versions.txt: for normal releases updates all entries to version:version, for snapshot releases updates entries to previous-release:snapshot-release.
  • pom.xml: update to <version>newVersion</version>.
  • README.md: update examples of Java, Scala, and Groovy imports.

@chingor13 please take a look and let me know if the logic looks right, tomorrow I'll actually integrate it with the CLI and we can play around.

@bcoe bcoe requested a review from chingor13 July 17, 2019 00:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #203 into master will decrease coverage by 3.39%.
The diff coverage is 54.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #203     +/-   ##
=========================================
- Coverage   74.91%   71.51%   -3.4%     
=========================================
  Files          15       18      +3     
  Lines        2125     2514    +389     
  Branches      156      173     +17     
=========================================
+ Hits         1592     1798    +206     
- Misses        522      704    +182     
- Partials       11       12      +1
Impacted Files Coverage Δ
src/updaters/java-auth-versions.ts 100% <100%> (ø)
src/graphql-to-commits.ts 93.82% <100%> (+0.49%) ⬆️
src/updaters/pom-xml.ts 100% <100%> (ø)
src/updaters/java-auth-readme.ts 100% <100%> (ø)
src/release-pr.ts 60.76% <16.92%> (-12.33%) ⬇️
src/github.ts 54.6% <6.41%> (-5.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11833d...bb12ca1. Read the comment docs.

# Format:
# module:released-version:current-version

google-auth-library:0.16.2:0.16.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally, the state of the repo will have the current-version be a SNAPSHOT version. In this case, it would be 0.16.3-SNAPSHOT

<parent>
<groupId>com.google.auth</groupId>
<artifactId>google-auth-library-parent</artifactId>
<version>0.16.2</version><!-- {x-version-update:google-auth-library-parent:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally, the state of the repo will have the current-version be a SNAPSHOT version. In this case, it would be 0.16.3-SNAPSHOT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few more test cases in the fixture for -alpha-SNAPSHOT, -SNAPSHOT, etc.

src/updaters/java-auth-readme.ts Show resolved Hide resolved
src/updaters/java-auth-versions.ts Show resolved Hide resolved
@bcoe bcoe merged commit f72c930 into master Jul 26, 2019
@bcoe bcoe deleted the java-auth-library branch July 26, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants