Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend release notes regex to support patches #142

Merged
merged 3 commits into from May 20, 2019
Merged

fix: extend release notes regex to support patches #142

merged 3 commits into from May 20, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 20, 2019 •
edited

fixes: #140

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@codecov
Copy link

codecov bot commented May 20, 2019 •
edited

Codecov Report

Merging #142 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   53.04%   53.11%   +0.07%     
==========================================
  Files           9        9              
  Lines        1299     1301       +2     
  Branches       72       72              
==========================================
+ Hits          689      691       +2     
  Misses        608      608              
  Partials        2        2
Impacted Files Coverage Δ
src/github-release.ts 56.52% <100%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3e962...ad6a463. Read the comment docs.

@bcoe
Copy link
Contributor Author

bcoe commented May 20, 2019

corresponding fix here: googleapis/releasetool#193

@bcoe bcoe merged commit e887626 into master May 20, 2019
@bcoe bcoe deleted the fix-140 branch May 20, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release notes improperly extracted from CHANGELOG.md
3 participants
@bcoe @JustinBeckwith @googlebot