Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if we generate a CHANGELOG with only a header, don't open a PR #132

Merged
merged 2 commits into from May 17, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 17, 2019

To test this, I also had to fix a bug with how we were comparing labels; we should ensure all labels match on the PR, not just one of them.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #132 into master will increase coverage by 0.03%.
The diff coverage is 44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   53.05%   53.09%   +0.03%     
==========================================
  Files           9        9              
  Lines        1293     1294       +1     
  Branches       70       70              
==========================================
+ Hits          686      687       +1     
  Misses        605      605              
  Partials        2        2
Impacted Files Coverage Δ
src/release-pr.ts 34.4% <0%> (-0.16%) ⬇️
src/github.ts 47.36% <78.57%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b2a08...54d92e8. Read the comment docs.

@bcoe bcoe merged commit ba68930 into master May 17, 2019
@bcoe bcoe deleted the fix-empty-changelog branch May 17, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants