fix: GitHub issues do not allow 'link comments' (#92)

googleapis · May 15, 2019 · fe4cd4f · fe4cd4f
1 parent 8a295b2
commit fe4cd4f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/__snapshots__/candidate-issue.js b/__snapshots__/candidate-issue.js
@@ -7,8 +7,6 @@ Features:
 * deps: upgrade foo
 
 
----
-
 
 `
 
@@ -21,9 +19,7 @@ Features:
 * deps: upgrade foo
 
 
----
-
-[//]: # footer follows.
+----------------
 
 * [ ] **Should I create this release for you :robot:?**
 

diff --git a/src/candidate-issue.ts b/src/candidate-issue.ts
@@ -26,7 +26,7 @@ import {ReleasePR, ReleasePROptions} from './release-pr';
 const parseGithubRepoUrl = require('parse-github-repo-url');
 
 const ISSUE_TITLE = 'chore(release): proposal for next release';
-const ISSUE_FOOTER = '[//]: # footer follows.';
+const ISSUE_FOOTER = '----------------';
 const CHECKBOX = '* [ ] **Should I create this release for you :robot:?**';
 const CHECK_REGEX = /\[x]/;
 
@@ -155,8 +155,6 @@ export class CandidateIssue {
 
 ${changelogEntry}
 
----
-
 ${ISSUE_FOOTER}
 
 ${CHECKBOX}

diff --git a/system-test/github.ts b/system-test/github.ts
@@ -165,9 +165,9 @@ describe('GitHub', () => {
                               });
                         });
          pr.should.eql({
-           version: 'v1.0.0',
-           sha: '5a4cdf2c1370937b363ce10962bf30e2ee84202e',
-           number: 3
+           version: 'v1.1.0',
+           sha: 'f52c585f1319b789ff75e864fe9bf7479f72ae0e',
+           number: 6
          });
        });
   });