Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After merging a release PR, a release is created but then a duplicate release PR is automatically opened #962

Open
megancoyle opened this issue Mar 21, 2024 · 2 comments

Comments

@megancoyle
Copy link

TL;DR

When using the release-please action, on triggering a release PR, if I merge in the release PR, a release will get created in the draft format, but a duplicate release PR will get opened

Here's an example of what the .release-please-manifest.json looks like:

{
  ".": "1.0.3"
}

Here's what the release-please-config.json looks like:

{
  "packages": {
    ".": {
      "release-type": "node",
      "draft": true,
      "include-component-in-tag": false
    }
  },
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

Expected behavior

After merging in a release PR, I was expecting a draft release to get created, and no other PR get automatically opened.

Observed behavior

Instead, a duplicate release PR of the one just merged, was getting opened.

Action YAML

name: Run release-please

on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Use latest release-please action
        uses: google-github-actions/release-please-action@v4
        with:
          token: ${{secrets.GITHUB_TOKEN}}
          config-file: release-please-config.json
          manifest-file: .release-please-manifest.json

Log output

No response

Additional information

No response

@megancoyle megancoyle added the bug label Mar 21, 2024
@megancoyle megancoyle changed the title After merging a release PR, a release is created but then another release PR is automatically opened After merging a release PR, a release is created but then a duplicate release PR is automatically opened Mar 21, 2024
@mirzak
Copy link

mirzak commented Apr 17, 2024

I have the same problem.

@d1onys1us
Copy link

this is also giving us issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants