Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prerelease not working #925

Open
dinjazelena opened this issue Jan 12, 2024 · 3 comments
Open

prerelease not working #925

dinjazelena opened this issue Jan 12, 2024 · 3 comments

Comments

@dinjazelena
Copy link

TL;DR

on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

name: release-please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v4
        with:
          release-type: python
          version-file: togusa/__init__.py
          prerelease: true
          prerelease-type: beta

Hi, so when i specify prerelease and prerelease type, nothing really happens it just creates regular Release and version bump.

I also get this warning:
Unexpected input(s) 'version-file', 'prerelease', 'prerelease-type', valid inputs are ['token', 'release-type', 'path', 'target-branch', 'config-file', 'manifest-file', 'repo-url', 'github-api-url', 'github-graphql-url', 'fork', 'include-component-in-tag', 'proxy-server', 'skip-github-release', 'skip-github-pull-request']

Expected behavior

Create a prerelase with beta added to version

Observed behavior

No response

Action YAML

on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

name: release-please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v4
        with:
          release-type: python
          version-file: togusa/__init__.py
          prerelease: true
          prerelease-type: beta

Log output

No response

Additional information

No response

@ju-Skinner
Copy link

ju-Skinner commented Jan 12, 2024

Hello, I was in the same boat as you. I thought the prerelease was related to the SemVer, but it is for the GitHub Release. meaning that your release will be created as a Draft.

Your error could be resolved following the steps here, which will have you create a manifest-file.

  // when `manifest-release` creates GitHub Releases per package, create
  // those as "Prerelease" releases that have pre-major or prerelease versions.
  // absence defaults to false and all versions are fully Published.
  "prerelease": true

https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md?plain=1#L191-L194

@dinjazelena
Copy link
Author

Thank u very much for help. But the thing is prerelease set to true in yml workflow wont even create Draft for me.
Could u reproduce minimal manifest-file for setting prerelease-type for python project?

@mewhhaha
Copy link

mewhhaha commented Apr 4, 2024

We had a similar issue with preleases where there was a field called "versioning" that needed to be set to "prerelease" for our beta prereleases to be working. It seems to be documented in the schema but couldn't find it in the manifest README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants