This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
fix: exclude docs and tests from package #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: workflows
google-cla
bot
added
the
cla: yes
Currently, packages `tests` and `docs` are installed (because they are discovered as valid packages by `PEP420PackageFinder`), which can break user's code if they also use `test` as a location for their tests, due to package name conflict.
parthea
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
added
the
automerge: exact
parthea
changed the title
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
dismissed
parthea’s stale review
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
parthea
approved these changes
Jun 17, 2021
parthea
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge: exact
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/python-workflows/compare/v1.1.0...v1.2.0) (2021-07-01) ### Features * add always_use_jwt_access ([#68](https://www.github.com/googleapis/python-workflows/issues/68)) ([a88f246](https://www.github.com/googleapis/python-workflows/commit/a88f2466a906fdec0ebf4d772967cdf334b8ac91)) ### Bug Fixes * disable always_use_jwt_access ([#72](https://www.github.com/googleapis/python-workflows/issues/72)) ([2085463](https://www.github.com/googleapis/python-workflows/commit/20854636d22eefd738872ef4fa8b280a2f6989ec)) * exclude docs and tests from package ([#63](https://www.github.com/googleapis/python-workflows/issues/63)) ([ff68d16](https://www.github.com/googleapis/python-workflows/commit/ff68d16bb68960dbee188771f6f334ab69a98b23)) ### Documentation * omit mention of Python 2.7 in 'CONTRIBUTING.rst' ([#1127](https://www.github.com/googleapis/python-workflows/issues/1127)) ([#65](https://www.github.com/googleapis/python-workflows/issues/65)) ([10341d6](https://www.github.com/googleapis/python-workflows/commit/10341d6b7adf284507d5f99dc68bae34e4360be9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, packages
testsanddocsare installed (because they are discovered as valid packages byPEP420PackageFinder), which can break user's code if they also usetestas a location for their tests, due to package name conflict.To reproduce - install this package from pypi, see that
testspackage is present in your venv's site-packages.This change pretty much follows what other Google packages do, eg here