Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat!: move to webrisk API to python microgenerator #27

Merged
merged 19 commits into from Jul 14, 2020
Merged

feat!: move to webrisk API to python microgenerator #27

merged 19 commits into from Jul 14, 2020

Conversation

xiaozhenliu-gg5
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
@xiaozhenliu-gg5
Copy link
Contributor Author

pythons -m nox fails for session.run("coverage", "report", "--show-missing", "--fail-under=") in noxfile.py. and --fail-under = 100 does not work because the coverage is 99%. So I manually added --fail-under=99 which works, but not sure if we want s.replace it in synth.py. @busunkim96 Thanks!

I tried s.replace("noxfile.py", """['"]--fail-under['"]""", '"--fail-under=99"') and s.replace("noxfile.py", "--fail-under", '--fail-under=99') which failed to generate what I expected. Please give some instructions.

@xiaozhenliu-gg5 xiaozhenliu-gg5 changed the title feat: move to webrisk API to python microgenerator feat!: move to webrisk API to python microgenerator Jul 9, 2020
busunkim96
busunkim96 reviewed Jul 9, 2020
View reviewed changes
synth.py Show resolved Hide resolved
busunkim96
busunkim96 reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the files under webrisk-v1-py. It also looks like this is missing an UPGRADING.md?

@xiaozhenliu-gg5
Copy link
Contributor Author

Please remove all the files under webrisk-v1-py.

curious that should I also remove webrisk-v1beta1-py, I tried to remove those two folders, and synthtool won't regenerate it back, is this expected? Thanks! @busunkim96

busunkim96
busunkim96 reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaozhenliu-gg5 Yep! The library code should go under google/cloud/...

UPGRADING.MD Outdated Show resolved Hide resolved
UPGRADING.MD Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
xiaozhenliu-gg5 and others added 3 commits July 14, 2020 10:16
@xiaozhenliu-gg5 @busunkim96
Update UPGRADING.MD
d544683 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@xiaozhenliu-gg5 @busunkim96
Update UPGRADING.MD
050b998 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@xiaozhenliu-gg5 @busunkim96
Update setup.py
b48f56f 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@busunkim96 busunkim96 merged commit bbd2adf into master Jul 14, 2020
@busunkim96 busunkim96 deleted the move-to-micro branch July 14, 2020 22:02
@release-please release-please bot mentioned this pull request Jul 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@software-dov software-dov Awaiting requested review from software-dov

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaozhenliu-gg5 @busunkim96 @googlebot