From cd6b816ece0ea0de28619d2072d980678e82c414 Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Mon, 1 Nov 2021 10:54:12 +0000 Subject: [PATCH] chore: use gapic-generator-python 0.53.4 (#62) - [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: https://github.com/googleapis/googleapis/commit/83d81b0c8fc22291a13398d6d77f02dc97a5b6f4 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2ff001fbacb9e77e71d734de5f955c05fdae8526 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9 --- .../vpc_access_service/async_client.py | 28 +++--- .../services/vpc_access_service/client.py | 10 +- .../vpc_access_service/transports/base.py | 37 +------- .../vpc_access_service/transports/grpc.py | 2 +- .../transports/grpc_asyncio.py | 3 +- setup.py | 3 +- testing/constraints-3.6.txt | 4 +- .../vpcaccess_v1/test_vpc_access_service.py | 91 ++----------------- 8 files changed, 36 insertions(+), 142 deletions(-) diff --git a/google/cloud/vpcaccess_v1/services/vpc_access_service/async_client.py b/google/cloud/vpcaccess_v1/services/vpc_access_service/async_client.py index 1ad1066..85bbd73 100644 --- a/google/cloud/vpcaccess_v1/services/vpc_access_service/async_client.py +++ b/google/cloud/vpcaccess_v1/services/vpc_access_service/async_client.py @@ -19,13 +19,15 @@ from typing import Dict, Sequence, Tuple, Type, Union import pkg_resources -import google.api_core.client_options as ClientOptions # type: ignore +from google.api_core.client_options import ClientOptions # type: ignore from google.api_core import exceptions as core_exceptions # type: ignore from google.api_core import gapic_v1 # type: ignore from google.api_core import retry as retries # type: ignore from google.auth import credentials as ga_credentials # type: ignore from google.oauth2 import service_account # type: ignore +OptionalRetry = Union[retries.Retry, object] + from google.api_core import operation # type: ignore from google.api_core import operation_async # type: ignore from google.cloud.vpcaccess_v1.services.vpc_access_service import pagers @@ -169,12 +171,12 @@ def __init__( async def create_connector( self, - request: vpc_access.CreateConnectorRequest = None, + request: Union[vpc_access.CreateConnectorRequest, dict] = None, *, parent: str = None, connector_id: str = None, connector: vpc_access.Connector = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> operation_async.AsyncOperation: @@ -182,7 +184,7 @@ async def create_connector( operation. Args: - request (:class:`google.cloud.vpcaccess_v1.types.CreateConnectorRequest`): + request (Union[google.cloud.vpcaccess_v1.types.CreateConnectorRequest, dict]): The request object. Request for creating a Serverless VPC Access connector. parent (:class:`str`): @@ -271,10 +273,10 @@ async def create_connector( async def get_connector( self, - request: vpc_access.GetConnectorRequest = None, + request: Union[vpc_access.GetConnectorRequest, dict] = None, *, name: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> vpc_access.Connector: @@ -282,7 +284,7 @@ async def get_connector( resource does not exist. Args: - request (:class:`google.cloud.vpcaccess_v1.types.GetConnectorRequest`): + request (Union[google.cloud.vpcaccess_v1.types.GetConnectorRequest, dict]): The request object. Request for getting a Serverless VPC Access connector. name (:class:`str`): @@ -343,17 +345,17 @@ async def get_connector( async def list_connectors( self, - request: vpc_access.ListConnectorsRequest = None, + request: Union[vpc_access.ListConnectorsRequest, dict] = None, *, parent: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> pagers.ListConnectorsAsyncPager: r"""Lists Serverless VPC Access connectors. Args: - request (:class:`google.cloud.vpcaccess_v1.types.ListConnectorsRequest`): + request (Union[google.cloud.vpcaccess_v1.types.ListConnectorsRequest, dict]): The request object. Request for listing Serverless VPC Access connectors in a location. parent (:class:`str`): @@ -423,10 +425,10 @@ async def list_connectors( async def delete_connector( self, - request: vpc_access.DeleteConnectorRequest = None, + request: Union[vpc_access.DeleteConnectorRequest, dict] = None, *, name: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> operation_async.AsyncOperation: @@ -434,7 +436,7 @@ async def delete_connector( the resource does not exist. Args: - request (:class:`google.cloud.vpcaccess_v1.types.DeleteConnectorRequest`): + request (Union[google.cloud.vpcaccess_v1.types.DeleteConnectorRequest, dict]): The request object. Request for deleting a Serverless VPC Access connector. name (:class:`str`): diff --git a/google/cloud/vpcaccess_v1/services/vpc_access_service/client.py b/google/cloud/vpcaccess_v1/services/vpc_access_service/client.py index 1ba4f1f..8da08af 100644 --- a/google/cloud/vpcaccess_v1/services/vpc_access_service/client.py +++ b/google/cloud/vpcaccess_v1/services/vpc_access_service/client.py @@ -30,6 +30,8 @@ from google.auth.exceptions import MutualTLSChannelError # type: ignore from google.oauth2 import service_account # type: ignore +OptionalRetry = Union[retries.Retry, object] + from google.api_core import operation # type: ignore from google.api_core import operation_async # type: ignore from google.cloud.vpcaccess_v1.services.vpc_access_service import pagers @@ -360,7 +362,7 @@ def create_connector( parent: str = None, connector_id: str = None, connector: vpc_access.Connector = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> operation.Operation: @@ -460,7 +462,7 @@ def get_connector( request: Union[vpc_access.GetConnectorRequest, dict] = None, *, name: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> vpc_access.Connector: @@ -532,7 +534,7 @@ def list_connectors( request: Union[vpc_access.ListConnectorsRequest, dict] = None, *, parent: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> pagers.ListConnectorsPager: @@ -612,7 +614,7 @@ def delete_connector( request: Union[vpc_access.DeleteConnectorRequest, dict] = None, *, name: str = None, - retry: retries.Retry = gapic_v1.method.DEFAULT, + retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: float = None, metadata: Sequence[Tuple[str, str]] = (), ) -> operation.Operation: diff --git a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/base.py b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/base.py index 5d6882a..feef2e1 100644 --- a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/base.py +++ b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/base.py @@ -15,7 +15,6 @@ # import abc from typing import Awaitable, Callable, Dict, Optional, Sequence, Union -import packaging.version import pkg_resources import google.auth # type: ignore @@ -39,15 +38,6 @@ except pkg_resources.DistributionNotFound: DEFAULT_CLIENT_INFO = gapic_v1.client_info.ClientInfo() -try: - # google.auth.__version__ was added in 1.26.0 - _GOOGLE_AUTH_VERSION = google.auth.__version__ -except AttributeError: - try: # try pkg_resources if it is available - _GOOGLE_AUTH_VERSION = pkg_resources.get_distribution("google-auth").version - except pkg_resources.DistributionNotFound: # pragma: NO COVER - _GOOGLE_AUTH_VERSION = None - class VpcAccessServiceTransport(abc.ABC): """Abstract transport class for VpcAccessService.""" @@ -97,7 +87,7 @@ def __init__( host += ":443" self._host = host - scopes_kwargs = self._get_scopes_kwargs(self._host, scopes) + scopes_kwargs = {"scopes": scopes, "default_scopes": self.AUTH_SCOPES} # Save the scopes. self._scopes = scopes @@ -130,29 +120,6 @@ def __init__( # Save the credentials. self._credentials = credentials - # TODO(busunkim): This method is in the base transport - # to avoid duplicating code across the transport classes. These functions - # should be deleted once the minimum required versions of google-auth is increased. - - # TODO: Remove this function once google-auth >= 1.25.0 is required - @classmethod - def _get_scopes_kwargs( - cls, host: str, scopes: Optional[Sequence[str]] - ) -> Dict[str, Optional[Sequence[str]]]: - """Returns scopes kwargs to pass to google-auth methods depending on the google-auth version""" - - scopes_kwargs = {} - - if _GOOGLE_AUTH_VERSION and ( - packaging.version.parse(_GOOGLE_AUTH_VERSION) - >= packaging.version.parse("1.25.0") - ): - scopes_kwargs = {"scopes": scopes, "default_scopes": cls.AUTH_SCOPES} - else: - scopes_kwargs = {"scopes": scopes or cls.AUTH_SCOPES} - - return scopes_kwargs - def _prep_wrapped_messages(self, client_info): # Precompute the wrapped methods. self._wrapped_methods = { @@ -180,7 +147,7 @@ def close(self): raise NotImplementedError() @property - def operations_client(self) -> operations_v1.OperationsClient: + def operations_client(self): """Return the client designed to process long-running operations.""" raise NotImplementedError() diff --git a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc.py b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc.py index 9bf76f5..0bb4c71 100644 --- a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc.py +++ b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc.py @@ -114,7 +114,7 @@ def __init__( self._grpc_channel = None self._ssl_channel_credentials = ssl_channel_credentials self._stubs: Dict[str, Callable] = {} - self._operations_client = None + self._operations_client: Optional[operations_v1.OperationsClient] = None if api_mtls_endpoint: warnings.warn("api_mtls_endpoint is deprecated", DeprecationWarning) diff --git a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc_asyncio.py b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc_asyncio.py index 93aa334..2656cb1 100644 --- a/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc_asyncio.py +++ b/google/cloud/vpcaccess_v1/services/vpc_access_service/transports/grpc_asyncio.py @@ -21,7 +21,6 @@ from google.api_core import operations_v1 # type: ignore from google.auth import credentials as ga_credentials # type: ignore from google.auth.transport.grpc import SslCredentials # type: ignore -import packaging.version import grpc # type: ignore from grpc.experimental import aio # type: ignore @@ -161,7 +160,7 @@ def __init__( self._grpc_channel = None self._ssl_channel_credentials = ssl_channel_credentials self._stubs: Dict[str, Callable] = {} - self._operations_client = None + self._operations_client: Optional[operations_v1.OperationsAsyncClient] = None if api_mtls_endpoint: warnings.warn("api_mtls_endpoint is deprecated", DeprecationWarning) diff --git a/setup.py b/setup.py index 5c9a10f..765d4cd 100644 --- a/setup.py +++ b/setup.py @@ -29,9 +29,8 @@ # NOTE: Maintainers, please do not require google-api-core>=2.x.x # Until this issue is closed # https://github.com/googleapis/google-cloud-python/issues/10566 - "google-api-core[grpc] >= 1.26.0, <3.0.0dev", + "google-api-core[grpc] >= 1.28.0, <3.0.0dev", "proto-plus >= 1.15.0", - "packaging >= 14.3", ] package_root = os.path.abspath(os.path.dirname(__file__)) diff --git a/testing/constraints-3.6.txt b/testing/constraints-3.6.txt index 4bd5e67..1e3ec8b 100644 --- a/testing/constraints-3.6.txt +++ b/testing/constraints-3.6.txt @@ -4,7 +4,5 @@ # Pin the version to the lower bound. # e.g., if setup.py has "google-cloud-foo >= 1.14.0, < 2.0.0dev", # Then this file should have google-cloud-foo==1.14.0 -google-api-core==1.26.0 +google-api-core==1.28.0 proto-plus==1.15.0 -packaging==14.3 -google-auth==1.24.0 # TODO: remove when google-auth>=1.25.0 si transitively required through google-api-core diff --git a/tests/unit/gapic/vpcaccess_v1/test_vpc_access_service.py b/tests/unit/gapic/vpcaccess_v1/test_vpc_access_service.py index 727f2ba..ae73e5f 100644 --- a/tests/unit/gapic/vpcaccess_v1/test_vpc_access_service.py +++ b/tests/unit/gapic/vpcaccess_v1/test_vpc_access_service.py @@ -15,7 +15,6 @@ # import os import mock -import packaging.version import grpc from grpc.experimental import aio @@ -41,29 +40,12 @@ from google.cloud.vpcaccess_v1.services.vpc_access_service import VpcAccessServiceClient from google.cloud.vpcaccess_v1.services.vpc_access_service import pagers from google.cloud.vpcaccess_v1.services.vpc_access_service import transports -from google.cloud.vpcaccess_v1.services.vpc_access_service.transports.base import ( - _GOOGLE_AUTH_VERSION, -) from google.cloud.vpcaccess_v1.types import vpc_access from google.longrunning import operations_pb2 from google.oauth2 import service_account import google.auth -# TODO(busunkim): Once google-auth >= 1.25.0 is required transitively -# through google-api-core: -# - Delete the auth "less than" test cases -# - Delete these pytest markers (Make the "greater than or equal to" tests the default). -requires_google_auth_lt_1_25_0 = pytest.mark.skipif( - packaging.version.parse(_GOOGLE_AUTH_VERSION) >= packaging.version.parse("1.25.0"), - reason="This test requires google-auth < 1.25.0", -) -requires_google_auth_gte_1_25_0 = pytest.mark.skipif( - packaging.version.parse(_GOOGLE_AUTH_VERSION) < packaging.version.parse("1.25.0"), - reason="This test requires google-auth >= 1.25.0", -) - - def client_cert_source_callback(): return b"cert bytes", b"key bytes" @@ -221,7 +203,7 @@ def test_vpc_access_service_client_client_options( options = client_options.ClientOptions(api_endpoint="squid.clam.whelk") with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class(client_options=options) + client = client_class(transport=transport_name, client_options=options) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -238,7 +220,7 @@ def test_vpc_access_service_client_client_options( with mock.patch.dict(os.environ, {"GOOGLE_API_USE_MTLS_ENDPOINT": "never"}): with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class() + client = client_class(transport=transport_name) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -255,7 +237,7 @@ def test_vpc_access_service_client_client_options( with mock.patch.dict(os.environ, {"GOOGLE_API_USE_MTLS_ENDPOINT": "always"}): with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class() + client = client_class(transport=transport_name) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -284,7 +266,7 @@ def test_vpc_access_service_client_client_options( options = client_options.ClientOptions(quota_project_id="octopus") with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class(client_options=options) + client = client_class(transport=transport_name, client_options=options) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -353,7 +335,7 @@ def test_vpc_access_service_client_mtls_env_auto( ) with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class(client_options=options) + client = client_class(transport=transport_name, client_options=options) if use_client_cert_env == "false": expected_client_cert_source = None @@ -395,7 +377,7 @@ def test_vpc_access_service_client_mtls_env_auto( expected_client_cert_source = client_cert_source_callback patched.return_value = None - client = client_class() + client = client_class(transport=transport_name) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -417,7 +399,7 @@ def test_vpc_access_service_client_mtls_env_auto( return_value=False, ): patched.return_value = None - client = client_class() + client = client_class(transport=transport_name) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -448,7 +430,7 @@ def test_vpc_access_service_client_client_options_scopes( options = client_options.ClientOptions(scopes=["1", "2"],) with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class(client_options=options) + client = client_class(transport=transport_name, client_options=options) patched.assert_called_once_with( credentials=None, credentials_file=None, @@ -479,7 +461,7 @@ def test_vpc_access_service_client_client_options_credentials_file( options = client_options.ClientOptions(credentials_file="credentials.json") with mock.patch.object(transport_class, "__init__") as patched: patched.return_value = None - client = client_class(client_options=options) + client = client_class(transport=transport_name, client_options=options) patched.assert_called_once_with( credentials=None, credentials_file="credentials.json", @@ -1621,7 +1603,6 @@ def test_vpc_access_service_base_transport(): transport.operations_client -@requires_google_auth_gte_1_25_0 def test_vpc_access_service_base_transport_with_credentials_file(): # Instantiate the base transport with a credentials file with mock.patch.object( @@ -1642,26 +1623,6 @@ def test_vpc_access_service_base_transport_with_credentials_file(): ) -@requires_google_auth_lt_1_25_0 -def test_vpc_access_service_base_transport_with_credentials_file_old_google_auth(): - # Instantiate the base transport with a credentials file - with mock.patch.object( - google.auth, "load_credentials_from_file", autospec=True - ) as load_creds, mock.patch( - "google.cloud.vpcaccess_v1.services.vpc_access_service.transports.VpcAccessServiceTransport._prep_wrapped_messages" - ) as Transport: - Transport.return_value = None - load_creds.return_value = (ga_credentials.AnonymousCredentials(), None) - transport = transports.VpcAccessServiceTransport( - credentials_file="credentials.json", quota_project_id="octopus", - ) - load_creds.assert_called_once_with( - "credentials.json", - scopes=("https://www.googleapis.com/auth/cloud-platform",), - quota_project_id="octopus", - ) - - def test_vpc_access_service_base_transport_with_adc(): # Test the default credentials are used if credentials and credentials_file are None. with mock.patch.object(google.auth, "default", autospec=True) as adc, mock.patch( @@ -1673,7 +1634,6 @@ def test_vpc_access_service_base_transport_with_adc(): adc.assert_called_once() -@requires_google_auth_gte_1_25_0 def test_vpc_access_service_auth_adc(): # If no credentials are provided, we should use ADC credentials. with mock.patch.object(google.auth, "default", autospec=True) as adc: @@ -1686,18 +1646,6 @@ def test_vpc_access_service_auth_adc(): ) -@requires_google_auth_lt_1_25_0 -def test_vpc_access_service_auth_adc_old_google_auth(): - # If no credentials are provided, we should use ADC credentials. - with mock.patch.object(google.auth, "default", autospec=True) as adc: - adc.return_value = (ga_credentials.AnonymousCredentials(), None) - VpcAccessServiceClient() - adc.assert_called_once_with( - scopes=("https://www.googleapis.com/auth/cloud-platform",), - quota_project_id=None, - ) - - @pytest.mark.parametrize( "transport_class", [ @@ -1705,7 +1653,6 @@ def test_vpc_access_service_auth_adc_old_google_auth(): transports.VpcAccessServiceGrpcAsyncIOTransport, ], ) -@requires_google_auth_gte_1_25_0 def test_vpc_access_service_transport_auth_adc(transport_class): # If credentials and host are not provided, the transport class should use # ADC credentials. @@ -1719,26 +1666,6 @@ def test_vpc_access_service_transport_auth_adc(transport_class): ) -@pytest.mark.parametrize( - "transport_class", - [ - transports.VpcAccessServiceGrpcTransport, - transports.VpcAccessServiceGrpcAsyncIOTransport, - ], -) -@requires_google_auth_lt_1_25_0 -def test_vpc_access_service_transport_auth_adc_old_google_auth(transport_class): - # If credentials and host are not provided, the transport class should use - # ADC credentials. - with mock.patch.object(google.auth, "default", autospec=True) as adc: - adc.return_value = (ga_credentials.AnonymousCredentials(), None) - transport_class(quota_project_id="octopus") - adc.assert_called_once_with( - scopes=("https://www.googleapis.com/auth/cloud-platform",), - quota_project_id="octopus", - ) - - @pytest.mark.parametrize( "transport_class,grpc_helpers", [