This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
fix: Fixes VPCSC Tests that did not conform to V2.0.0 client API #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client now requires either one positional argument or individual keyword arguments for each call.
The fix in the previous commit worked for the test_async_batch_annotate_images_write_blocked test. This commit updates other VPCSC tests to also work with the new client.
setting request to the dict didnt work.
google-cla
bot
added
the
cla: yes
sid-dinesh94
changed the title
busunkim96
approved these changes
Oct 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> 馃
Following the migration of the client to V2.0.0, these VPCSC specific tests started failing with syntax/typing errors.
This PR uses the keyword argument style for the client methods to fix the broken tests.