Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix: moves region tags #103

Merged
merged 4 commits into from Jan 13, 2021
Merged

fix: moves region tags #103

merged 4 commits into from Jan 13, 2021

Conversation

telpirion
Copy link
Contributor

This PR moves the region tags for the Translate v2 code snippets. It ensures that the snippets include function parameters when they are displayed on cloud.google.com.

For example, the following snippet should display the default setting for model:
https://cloud.google.com/translate/docs/basic/translating-text#translate_text_with_model-python

@telpirion telpirion requested review from sirtorry and a team as code owners January 12, 2021 18:53
@telpirion telpirion requested review from busunkim96 and removed request for a team January 12, 2021 18:53
@product-auto-label product-auto-label bot added the api: translate Issues related to the googleapis/python-translate API. label Jan 12, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 12, 2021 •
edited

Here is the summary of changes.

You added 5 region tags.
You deleted 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
leahecole
leahecole approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole
Copy link
Contributor

I'm not sure why the CLA bot is barfing but we can try a kokoro rerun to see if that fixes things

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2021
@leahecole leahecole added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 13, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 13, 2021
@leahecole leahecole merged commit e161eb5 into master Jan 13, 2021
@telpirion
Copy link
Contributor Author

Yay! Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leahecole leahecole leahecole approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@lucaswadedavis lucaswadedavis Awaiting requested review from lucaswadedavis

Assignees
No one assigned
Labels
api: translate Issues related to the googleapis/python-translate API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@telpirion @leahecole @yoshi-kokoro