From a334317bc34b8927adfbc4a2559dbb71ee22c78d Mon Sep 17 00:00:00 2001 From: Dan O'Meara Date: Fri, 7 Aug 2020 19:25:39 -0700 Subject: [PATCH] fix: update retry and timeout config (#39) * feat: regenerate library using Bazel adds additional module name overrides sets default timeout and retry config in base * chore: corrects module name in setup.py --- .coveragerc | 5 ++ docs/translate_v3/services.rst | 4 +- docs/translate_v3/types.rst | 4 +- docs/translate_v3beta1/services.rst | 4 +- docs/translate_v3beta1/types.rst | 4 +- google/cloud/translate/py.typed | 2 +- google/cloud/translate_v3/py.typed | 2 +- .../translation_service/async_client.py | 52 +++++++++++++---- .../services/translation_service/client.py | 4 +- .../translation_service/transports/base.py | 58 +++++++++++++++---- google/cloud/translate_v3beta1/py.typed | 2 +- .../translation_service/async_client.py | 52 +++++++++++++---- .../services/translation_service/client.py | 4 +- .../translation_service/transports/base.py | 58 +++++++++++++++---- ...ords.py => fixup_translate_v3_keywords.py} | 6 +- ...py => fixup_translate_v3beta1_keywords.py} | 6 +- setup.py | 4 +- synth.metadata | 20 ++----- synth.py | 25 +------- 19 files changed, 211 insertions(+), 105 deletions(-) rename scripts/{fixup_translation_v3_keywords.py => fixup_translate_v3_keywords.py} (97%) rename scripts/{fixup_translation_v3beta1_keywords.py => fixup_translate_v3beta1_keywords.py} (97%) diff --git a/.coveragerc b/.coveragerc index b6b6f7b3..d9205f04 100644 --- a/.coveragerc +++ b/.coveragerc @@ -28,6 +28,11 @@ exclude_lines = def __repr__ # Ignore abstract methods raise NotImplementedError + # Ignore pkg_resources exceptions. + # This is added at the module level as a safeguard for if someone + # generates the code and tries to run it without pip installing. This + # makes it virtually impossible to test properly. + except pkg_resources.DistributionNotFound omit = */gapic/*.py */proto/*.py diff --git a/docs/translate_v3/services.rst b/docs/translate_v3/services.rst index 8400587e..ce46a05d 100644 --- a/docs/translate_v3/services.rst +++ b/docs/translate_v3/services.rst @@ -1,5 +1,5 @@ -Services for Google Cloud Translation v3 API -============================================ +Services for Google Cloud Translate v3 API +========================================== .. automodule:: google.cloud.translate_v3.services.translation_service :members: diff --git a/docs/translate_v3/types.rst b/docs/translate_v3/types.rst index a126067f..f84d4f23 100644 --- a/docs/translate_v3/types.rst +++ b/docs/translate_v3/types.rst @@ -1,5 +1,5 @@ -Types for Google Cloud Translation v3 API -========================================= +Types for Google Cloud Translate v3 API +======================================= .. automodule:: google.cloud.translate_v3.types :members: diff --git a/docs/translate_v3beta1/services.rst b/docs/translate_v3beta1/services.rst index eb522c99..4fc95083 100644 --- a/docs/translate_v3beta1/services.rst +++ b/docs/translate_v3beta1/services.rst @@ -1,5 +1,5 @@ -Services for Google Cloud Translation v3beta1 API -================================================= +Services for Google Cloud Translate v3beta1 API +=============================================== .. automodule:: google.cloud.translate_v3beta1.services.translation_service :members: diff --git a/docs/translate_v3beta1/types.rst b/docs/translate_v3beta1/types.rst index aaf04973..32f1a720 100644 --- a/docs/translate_v3beta1/types.rst +++ b/docs/translate_v3beta1/types.rst @@ -1,5 +1,5 @@ -Types for Google Cloud Translation v3beta1 API -============================================== +Types for Google Cloud Translate v3beta1 API +============================================ .. automodule:: google.cloud.translate_v3beta1.types :members: diff --git a/google/cloud/translate/py.typed b/google/cloud/translate/py.typed index dd819a47..39eb1d6c 100644 --- a/google/cloud/translate/py.typed +++ b/google/cloud/translate/py.typed @@ -1,2 +1,2 @@ # Marker file for PEP 561. -# The google-cloud-translation package uses inline types. +# The google-cloud-translate package uses inline types. diff --git a/google/cloud/translate_v3/py.typed b/google/cloud/translate_v3/py.typed index dd819a47..39eb1d6c 100644 --- a/google/cloud/translate_v3/py.typed +++ b/google/cloud/translate_v3/py.typed @@ -1,2 +1,2 @@ # Marker file for PEP 561. -# The google-cloud-translation package uses inline types. +# The google-cloud-translate package uses inline types. diff --git a/google/cloud/translate_v3/services/translation_service/async_client.py b/google/cloud/translate_v3/services/translation_service/async_client.py index 66552ce7..9cb9b9d8 100644 --- a/google/cloud/translate_v3/services/translation_service/async_client.py +++ b/google/cloud/translate_v3/services/translation_service/async_client.py @@ -247,7 +247,7 @@ async def translate_text( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -367,7 +367,7 @@ async def detect_language( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.detect_language, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -485,7 +485,15 @@ async def get_supported_languages( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.get_supported_languages, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -549,7 +557,7 @@ async def batch_translate_text( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.batch_translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -638,7 +646,7 @@ async def create_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.create_glossary, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -720,7 +728,15 @@ async def list_glossaries( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.list_glossaries, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -797,7 +813,15 @@ async def get_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.get_glossary, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -874,7 +898,15 @@ async def delete_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.delete_glossary, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -901,9 +933,7 @@ async def delete_glossary( try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() diff --git a/google/cloud/translate_v3/services/translation_service/client.py b/google/cloud/translate_v3/services/translation_service/client.py index 097743cb..d00cd12d 100644 --- a/google/cloud/translate_v3/services/translation_service/client.py +++ b/google/cloud/translate_v3/services/translation_service/client.py @@ -1057,9 +1057,7 @@ def delete_glossary( try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() diff --git a/google/cloud/translate_v3/services/translation_service/transports/base.py b/google/cloud/translate_v3/services/translation_service/transports/base.py index d32c016c..ad022171 100644 --- a/google/cloud/translate_v3/services/translation_service/transports/base.py +++ b/google/cloud/translate_v3/services/translation_service/transports/base.py @@ -32,9 +32,7 @@ try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() @@ -106,32 +104,70 @@ def _prep_wrapped_messages(self): # Precompute the wrapped methods. self._wrapped_methods = { self.translate_text: gapic_v1.method.wrap_method( - self.translate_text, default_timeout=None, client_info=_client_info, + self.translate_text, default_timeout=600.0, client_info=_client_info, ), self.detect_language: gapic_v1.method.wrap_method( - self.detect_language, default_timeout=None, client_info=_client_info, + self.detect_language, default_timeout=600.0, client_info=_client_info, ), self.get_supported_languages: gapic_v1.method.wrap_method( self.get_supported_languages, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ), self.batch_translate_text: gapic_v1.method.wrap_method( self.batch_translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ), self.create_glossary: gapic_v1.method.wrap_method( - self.create_glossary, default_timeout=None, client_info=_client_info, + self.create_glossary, default_timeout=600.0, client_info=_client_info, ), self.list_glossaries: gapic_v1.method.wrap_method( - self.list_glossaries, default_timeout=None, client_info=_client_info, + self.list_glossaries, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), self.get_glossary: gapic_v1.method.wrap_method( - self.get_glossary, default_timeout=None, client_info=_client_info, + self.get_glossary, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), self.delete_glossary: gapic_v1.method.wrap_method( - self.delete_glossary, default_timeout=None, client_info=_client_info, + self.delete_glossary, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), } diff --git a/google/cloud/translate_v3beta1/py.typed b/google/cloud/translate_v3beta1/py.typed index dd819a47..39eb1d6c 100644 --- a/google/cloud/translate_v3beta1/py.typed +++ b/google/cloud/translate_v3beta1/py.typed @@ -1,2 +1,2 @@ # Marker file for PEP 561. -# The google-cloud-translation package uses inline types. +# The google-cloud-translate package uses inline types. diff --git a/google/cloud/translate_v3beta1/services/translation_service/async_client.py b/google/cloud/translate_v3beta1/services/translation_service/async_client.py index c7908f2b..fe0e508b 100644 --- a/google/cloud/translate_v3beta1/services/translation_service/async_client.py +++ b/google/cloud/translate_v3beta1/services/translation_service/async_client.py @@ -131,7 +131,7 @@ async def translate_text( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -242,7 +242,7 @@ async def detect_language( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.detect_language, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -360,7 +360,15 @@ async def get_supported_languages( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.get_supported_languages, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -424,7 +432,7 @@ async def batch_translate_text( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.batch_translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -513,7 +521,7 @@ async def create_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.create_glossary, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ) @@ -607,7 +615,15 @@ async def list_glossaries( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.list_glossaries, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -684,7 +700,15 @@ async def get_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.get_glossary, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -761,7 +785,15 @@ async def delete_glossary( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.delete_glossary, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ) @@ -788,9 +820,7 @@ async def delete_glossary( try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() diff --git a/google/cloud/translate_v3beta1/services/translation_service/client.py b/google/cloud/translate_v3beta1/services/translation_service/client.py index b4efa659..6d991415 100644 --- a/google/cloud/translate_v3beta1/services/translation_service/client.py +++ b/google/cloud/translate_v3beta1/services/translation_service/client.py @@ -943,9 +943,7 @@ def delete_glossary( try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() diff --git a/google/cloud/translate_v3beta1/services/translation_service/transports/base.py b/google/cloud/translate_v3beta1/services/translation_service/transports/base.py index 35c84f1c..b532a056 100644 --- a/google/cloud/translate_v3beta1/services/translation_service/transports/base.py +++ b/google/cloud/translate_v3beta1/services/translation_service/transports/base.py @@ -32,9 +32,7 @@ try: _client_info = gapic_v1.client_info.ClientInfo( - gapic_version=pkg_resources.get_distribution( - "google-cloud-translation", - ).version, + gapic_version=pkg_resources.get_distribution("google-cloud-translate",).version, ) except pkg_resources.DistributionNotFound: _client_info = gapic_v1.client_info.ClientInfo() @@ -106,32 +104,70 @@ def _prep_wrapped_messages(self): # Precompute the wrapped methods. self._wrapped_methods = { self.translate_text: gapic_v1.method.wrap_method( - self.translate_text, default_timeout=None, client_info=_client_info, + self.translate_text, default_timeout=600.0, client_info=_client_info, ), self.detect_language: gapic_v1.method.wrap_method( - self.detect_language, default_timeout=None, client_info=_client_info, + self.detect_language, default_timeout=600.0, client_info=_client_info, ), self.get_supported_languages: gapic_v1.method.wrap_method( self.get_supported_languages, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, client_info=_client_info, ), self.batch_translate_text: gapic_v1.method.wrap_method( self.batch_translate_text, - default_timeout=None, + default_timeout=600.0, client_info=_client_info, ), self.create_glossary: gapic_v1.method.wrap_method( - self.create_glossary, default_timeout=None, client_info=_client_info, + self.create_glossary, default_timeout=600.0, client_info=_client_info, ), self.list_glossaries: gapic_v1.method.wrap_method( - self.list_glossaries, default_timeout=None, client_info=_client_info, + self.list_glossaries, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), self.get_glossary: gapic_v1.method.wrap_method( - self.get_glossary, default_timeout=None, client_info=_client_info, + self.get_glossary, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), self.delete_glossary: gapic_v1.method.wrap_method( - self.delete_glossary, default_timeout=None, client_info=_client_info, + self.delete_glossary, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + exceptions.DeadlineExceeded, exceptions.ServiceUnavailable, + ), + ), + default_timeout=600.0, + client_info=_client_info, ), } diff --git a/scripts/fixup_translation_v3_keywords.py b/scripts/fixup_translate_v3_keywords.py similarity index 97% rename from scripts/fixup_translation_v3_keywords.py rename to scripts/fixup_translate_v3_keywords.py index 60b6c6d3..0f8aaa48 100644 --- a/scripts/fixup_translation_v3_keywords.py +++ b/scripts/fixup_translate_v3_keywords.py @@ -37,7 +37,7 @@ def partition( return results[1], results[0] -class translationCallTransformer(cst.CSTTransformer): +class translateCallTransformer(cst.CSTTransformer): CTRL_PARAMS: Tuple[str] = ('retry', 'timeout', 'metadata') METHOD_TO_PARAMS: Dict[str, Tuple[str]] = { 'batch_translate_text': ('parent', 'source_language_code', 'target_language_codes', 'input_configs', 'output_config', 'models', 'glossaries', 'labels', ), @@ -97,7 +97,7 @@ def fix_files( in_dir: pathlib.Path, out_dir: pathlib.Path, *, - transformer=translationCallTransformer(), + transformer=translateCallTransformer(), ): """Duplicate the input dir to the output dir, fixing file method calls. @@ -130,7 +130,7 @@ def fix_files( if __name__ == '__main__': parser = argparse.ArgumentParser( - description="""Fix up source that uses the translation client library. + description="""Fix up source that uses the translate client library. The existing sources are NOT overwritten but are copied to output_dir with changes made. diff --git a/scripts/fixup_translation_v3beta1_keywords.py b/scripts/fixup_translate_v3beta1_keywords.py similarity index 97% rename from scripts/fixup_translation_v3beta1_keywords.py rename to scripts/fixup_translate_v3beta1_keywords.py index 60b6c6d3..0f8aaa48 100644 --- a/scripts/fixup_translation_v3beta1_keywords.py +++ b/scripts/fixup_translate_v3beta1_keywords.py @@ -37,7 +37,7 @@ def partition( return results[1], results[0] -class translationCallTransformer(cst.CSTTransformer): +class translateCallTransformer(cst.CSTTransformer): CTRL_PARAMS: Tuple[str] = ('retry', 'timeout', 'metadata') METHOD_TO_PARAMS: Dict[str, Tuple[str]] = { 'batch_translate_text': ('parent', 'source_language_code', 'target_language_codes', 'input_configs', 'output_config', 'models', 'glossaries', 'labels', ), @@ -97,7 +97,7 @@ def fix_files( in_dir: pathlib.Path, out_dir: pathlib.Path, *, - transformer=translationCallTransformer(), + transformer=translateCallTransformer(), ): """Duplicate the input dir to the output dir, fixing file method calls. @@ -130,7 +130,7 @@ def fix_files( if __name__ == '__main__': parser = argparse.ArgumentParser( - description="""Fix up source that uses the translation client library. + description="""Fix up source that uses the translate client library. The existing sources are NOT overwritten but are copied to output_dir with changes made. diff --git a/setup.py b/setup.py index 59edcb15..1df70c1a 100644 --- a/setup.py +++ b/setup.py @@ -83,8 +83,8 @@ platforms="Posix; MacOS X; Windows", packages=packages, scripts=[ - "scripts/fixup_translation_v3_keywords.py", - "scripts/fixup_translation_v3beta1_keywords.py", + "scripts/fixup_translate_v3_keywords.py", + "scripts/fixup_translate_v3beta1_keywords.py", ], namespace_packages=namespaces, install_requires=dependencies, diff --git a/synth.metadata b/synth.metadata index 21dd9dcf..32b3b56a 100644 --- a/synth.metadata +++ b/synth.metadata @@ -3,30 +3,22 @@ { "git": { "name": ".", - "remote": "https://github.com/googleapis/python-translate.git", - "sha": "3758c8fc27e7ef052e215c720c5d64a8cb349bf1" - } - }, - { - "git": { - "name": "googleapis", - "remote": "https://github.com/googleapis/googleapis.git", - "sha": "868615a5c1c1059c636bb3d82a555edb1d5a251e", - "internalRef": "324294521" + "remote": "git@github.com:danoscarmike/python-translate", + "sha": "2a80f87c6ff441fb81161db8cda1049aa6851cc4" } }, { "git": { "name": "synthtool", "remote": "https://github.com/googleapis/synthtool.git", - "sha": "4f8f5dc24af79694887385015294e4dbb214c352" + "sha": "5f2f711c91199ba2f609d3f06a2fe22aee4e5be3" } }, { "git": { "name": "synthtool", "remote": "https://github.com/googleapis/synthtool.git", - "sha": "4f8f5dc24af79694887385015294e4dbb214c352" + "sha": "5f2f711c91199ba2f609d3f06a2fe22aee4e5be3" } } ], @@ -37,7 +29,7 @@ "apiName": "translate", "apiVersion": "v3beta1", "language": "python", - "generator": "gapic-generator-python" + "generator": "bazel" } }, { @@ -46,7 +38,7 @@ "apiName": "translate", "apiVersion": "v3", "language": "python", - "generator": "gapic-generator-python" + "generator": "bazel" } } ] diff --git a/synth.py b/synth.py index df2a8a73..8ca9bf33 100644 --- a/synth.py +++ b/synth.py @@ -18,7 +18,7 @@ from synthtool import gcp from synthtool.languages import python -gapic = gcp.GAPICMicrogenerator() +gapic = gcp.GAPICBazel() common = gcp.CommonTemplates() versions = ["v3beta1", "v3"] @@ -38,22 +38,9 @@ library = gapic.py_library( service="translate", version=version, - proto_path=f"google/cloud/translate/{version}" + bazel_target=f"//google/cloud/translate/{version}:translation-{version}-py", ) - - s.move(library / "google/cloud/translation", "google/cloud/translate") - s.move(library / f"google/cloud/translation_{version}", f"google/cloud/translate_{version}") - s.move(library / f"docs/translation_{version}", f"docs/translate_{version}") - s.move(library / f"tests/unit/gapic/translation_{version}", f"tests/unit/gapic/translate_{version}") - s.move(library / "scripts") - -# google.cloud.translation -> google.cloud.translate -s.replace( - ["google/cloud/translate*/**/*.py", "docs/translate_v*/*"], - " google.cloud.translation", - " google.cloud.translate" -) -s.replace("tests/**/*.py", "google.cloud.translation", "google.cloud.translate") + s.move(library, excludes=excludes) # TODO(danoscarmike): remove once upstream protos have been fixed # Escape underscores in gs:\\ URLs @@ -81,10 +68,4 @@ python.py_samples() -# ---------------------------------------------------------------------------- -# Samples templates -# ---------------------------------------------------------------------------- - -python.py_samples() - s.shell.run(["nox", "-s", "blacken"], hide_output=False)