Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Commit

Permalink
fix!: remove WALKING and CYCLING from v4 commute methods (#37)
Browse files Browse the repository at this point in the history
These methods are not available on the public v4 API.
  • Loading branch information
yoshi-automation committed Oct 2, 2020
1 parent 5c5a14c commit e239d24
Show file tree
Hide file tree
Showing 16 changed files with 240 additions and 385 deletions.
12 changes: 6 additions & 6 deletions .kokoro/samples/python3.8/common.cfg
Expand Up @@ -13,6 +13,12 @@ env_vars: {
value: "py-3.8"
}

# Declare build specific Cloud project.
env_vars: {
key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
value: "python-docs-samples-tests-py38"
}

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/python-talent/.kokoro/test-samples.sh"
Expand All @@ -24,12 +30,6 @@ env_vars: {
value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker"
}

# Declare build specific Cloud project.
env_vars: {
key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
value: "python-docs-samples-tests-py38"
}

# Download secrets for samples
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples"

Expand Down
188 changes: 60 additions & 128 deletions google/cloud/talent_v4/proto/common.proto

Large diffs are not rendered by default.

13 changes: 5 additions & 8 deletions google/cloud/talent_v4/proto/company.proto
Expand Up @@ -16,10 +16,10 @@ syntax = "proto3";

package google.cloud.talent.v4;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/cloud/talent/v4/common.proto";
import "google/api/annotations.proto";

option go_package = "google.golang.org/genproto/googleapis/cloud/talent/v4;talent";
option java_multiple_files = true;
Expand All @@ -39,8 +39,7 @@ message Company {
// Derived details about the company.
message DerivedInfo {
// A structured headquarters location of the company, resolved from
// [Company.headquarters_address][google.cloud.talent.v4.Company.headquarters_address]
// if provided.
// [Company.headquarters_address][google.cloud.talent.v4.Company.headquarters_address] if provided.
Location headquarters_location = 1;
}

Expand Down Expand Up @@ -69,8 +68,7 @@ message Company {
// The street address of the company's main headquarters, which may be
// different from the job location. The service attempts
// to geolocate the provided address, and populates a more specific
// location wherever possible in
// [DerivedInfo.headquarters_location][google.cloud.talent.v4.Company.DerivedInfo.headquarters_location].
// location wherever possible in [DerivedInfo.headquarters_location][google.cloud.talent.v4.Company.DerivedInfo.headquarters_location].
string headquarters_address = 5;

// Set to true if it is the hiring agency that post jobs for other
Expand Down Expand Up @@ -99,9 +97,8 @@ message Company {
// A URI that hosts the employer's company logo.
string image_uri = 10;

// A list of keys of filterable
// [Job.custom_attributes][google.cloud.talent.v4.Job.custom_attributes],
// whose corresponding `string_values` are used in keyword searches. Jobs with
// A list of keys of filterable [Job.custom_attributes][google.cloud.talent.v4.Job.custom_attributes], whose
// corresponding `string_values` are used in keyword searches. Jobs with
// `string_values` under these specified field keys are returned if any
// of the values match the search keyword. Custom field values with
// parenthesis, brackets and special symbols are not searchable as-is,
Expand Down
33 changes: 18 additions & 15 deletions google/cloud/talent_v4/proto/company_service.proto
Expand Up @@ -90,7 +90,9 @@ message CreateCompanyRequest {
// "projects/foo/tenants/bar".
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Tenant" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Tenant"
}
];

// Required. The company to be created.
Expand All @@ -106,26 +108,24 @@ message GetCompanyRequest {
// example, "projects/api-test-project/tenants/foo/companies/bar".
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Company" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Company"
}
];
}

// Request for updating a specified company.
message UpdateCompanyRequest {
// Required. The company resource to replace the current resource in the
// system.
// Required. The company resource to replace the current resource in the system.
Company company = 1 [(google.api.field_behavior) = REQUIRED];

// Strongly recommended for the best service experience.
//
// If [update_mask][google.cloud.talent.v4.UpdateCompanyRequest.update_mask]
// is provided, only the specified fields in
// [company][google.cloud.talent.v4.UpdateCompanyRequest.company] are updated.
// Otherwise all the fields are updated.
// If [update_mask][google.cloud.talent.v4.UpdateCompanyRequest.update_mask] is provided, only the specified fields in
// [company][google.cloud.talent.v4.UpdateCompanyRequest.company] are updated. Otherwise all the fields are updated.
//
// A field mask to specify the company fields to be updated. Only
// top level fields of [Company][google.cloud.talent.v4.Company] are
// supported.
// top level fields of [Company][google.cloud.talent.v4.Company] are supported.
google.protobuf.FieldMask update_mask = 2;
}

Expand All @@ -138,7 +138,9 @@ message DeleteCompanyRequest {
// example, "projects/foo/tenants/bar/companies/baz".
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Company" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Company"
}
];
}

Expand All @@ -150,7 +152,9 @@ message ListCompaniesRequest {
// "projects/foo/tenants/bar".
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Tenant" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Tenant"
}
];

// The starting indicator from which to return results.
Expand All @@ -164,9 +168,8 @@ message ListCompaniesRequest {
//
// Defaults to false.
//
// If true, at most
// [page_size][google.cloud.talent.v4.ListCompaniesRequest.page_size] of
// companies are fetched, among which only those with open jobs are returned.
// If true, at most [page_size][google.cloud.talent.v4.ListCompaniesRequest.page_size] of companies are fetched, among which
// only those with open jobs are returned.
bool require_open_jobs = 4;
}

Expand Down
43 changes: 17 additions & 26 deletions google/cloud/talent_v4/proto/completion_service.proto
Expand Up @@ -17,10 +17,10 @@ syntax = "proto3";
package google.cloud.talent.v4;

import "google/api/annotations.proto";
import "google/api/client.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/cloud/talent/v4/common.proto";
import "google/api/client.proto";

option go_package = "google.golang.org/genproto/googleapis/cloud/talent/v4;talent";
option java_multiple_files = true;
Expand Down Expand Up @@ -66,31 +66,22 @@ message CompleteQueryRequest {

// Suggest job titles for jobs autocomplete.
//
// For
// [CompletionType.JOB_TITLE][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.JOB_TITLE]
// type, only open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes]
// are returned.
// For [CompletionType.JOB_TITLE][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.JOB_TITLE] type, only open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes] are returned.
JOB_TITLE = 1;

// Suggest company names for jobs autocomplete.
//
// For
// [CompletionType.COMPANY_NAME][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMPANY_NAME]
// type, only companies having open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes]
// are returned.
// For [CompletionType.COMPANY_NAME][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMPANY_NAME] type,
// only companies having open jobs with the same [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes] are
// returned.
COMPANY_NAME = 2;

// Suggest both job titles and company names for jobs autocomplete.
//
// For
// [CompletionType.COMBINED][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMBINED]
// type, only open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes]
// or companies having open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes]
// are returned.
// For [CompletionType.COMBINED][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMBINED] type, only open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes] or companies having open jobs with the same
// [language_codes][google.cloud.talent.v4.CompleteQueryRequest.language_codes] are returned.
COMBINED = 3;
}

Expand All @@ -100,7 +91,9 @@ message CompleteQueryRequest {
// "projects/foo/tenants/bar".
string tenant = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Tenant" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Tenant"
}
];

// Required. The query used to generate suggestions.
Expand All @@ -126,16 +119,14 @@ message CompleteQueryRequest {
// The format is
// "projects/{project_id}/tenants/{tenant_id}/companies/{company_id}", for
// example, "projects/foo/tenants/bar/companies/baz".
string company = 5 [
(google.api.resource_reference) = { type: "jobs.googleapis.com/Company" }
];
string company = 5 [(google.api.resource_reference) = {
type: "jobs.googleapis.com/Company"
}];

// The scope of the completion. The defaults is
// [CompletionScope.PUBLIC][google.cloud.talent.v4.CompleteQueryRequest.CompletionScope.PUBLIC].
// The scope of the completion. The defaults is [CompletionScope.PUBLIC][google.cloud.talent.v4.CompleteQueryRequest.CompletionScope.PUBLIC].
CompletionScope scope = 6;

// The completion topic. The default is
// [CompletionType.COMBINED][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMBINED].
// The completion topic. The default is [CompletionType.COMBINED][google.cloud.talent.v4.CompleteQueryRequest.CompletionType.COMBINED].
CompletionType type = 7;
}

Expand Down
31 changes: 11 additions & 20 deletions google/cloud/talent_v4/proto/event.proto
Expand Up @@ -16,9 +16,9 @@ syntax = "proto3";

package google.cloud.talent.v4;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/protobuf/timestamp.proto";
import "google/api/annotations.proto";

option go_package = "google.golang.org/genproto/googleapis/cloud/talent/v4;talent";
option java_multiple_files = true;
Expand All @@ -42,8 +42,7 @@ message ClientEvent {
string event_id = 2 [(google.api.field_behavior) = REQUIRED];

// Required. The timestamp of the event.
google.protobuf.Timestamp create_time = 4
[(google.api.field_behavior) = REQUIRED];
google.protobuf.Timestamp create_time = 4 [(google.api.field_behavior) = REQUIRED];

// Required.
//
Expand Down Expand Up @@ -98,9 +97,7 @@ message JobEvent {
// submitted an application for a job with a single click without
// entering information. If a job seeker performs this action, send only
// this event to the service. Do not also send
// [JobEventType.APPLICATION_START][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_START]
// or
// [JobEventType.APPLICATION_FINISH][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_FINISH]
// [JobEventType.APPLICATION_START][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_START] or [JobEventType.APPLICATION_FINISH][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_FINISH]
// events.
APPLICATION_QUICK_SUBMISSION = 6;

Expand All @@ -120,11 +117,8 @@ message JobEvent {
// (without viewing the details of the job posting), and is redirected
// to a different website to complete the application. If a candidate
// performs this action, send only this event to the service. Do not also
// send
// [JobEventType.APPLICATION_START][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_START],
// [JobEventType.APPLICATION_FINISH][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_FINISH]
// or [JobEventType.VIEW][google.cloud.talent.v4.JobEvent.JobEventType.VIEW]
// events.
// send [JobEventType.APPLICATION_START][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_START],
// [JobEventType.APPLICATION_FINISH][google.cloud.talent.v4.JobEvent.JobEventType.APPLICATION_FINISH] or [JobEventType.VIEW][google.cloud.talent.v4.JobEvent.JobEventType.VIEW] events.
APPLICATION_REDIRECT_FROM_SEARCH = 9;

// This event should be used when a company submits an application
Expand Down Expand Up @@ -161,17 +155,14 @@ message JobEvent {
INTERVIEW_GRANTED = 15;
}

// Required. The type of the event (see
// [JobEventType][google.cloud.talent.v4.JobEvent.JobEventType]).
// Required. The type of the event (see [JobEventType][google.cloud.talent.v4.JobEvent.JobEventType]).
JobEventType type = 1 [(google.api.field_behavior) = REQUIRED];

// Required. The [job name(s)][google.cloud.talent.v4.Job.name] associated
// with this event. For example, if this is an
// [impression][google.cloud.talent.v4.JobEvent.JobEventType.IMPRESSION]
// event, this field contains the identifiers of all jobs shown to the job
// seeker. If this was a
// [view][google.cloud.talent.v4.JobEvent.JobEventType.VIEW] event, this field
// contains the identifier of the viewed job.
// Required. The [job name(s)][google.cloud.talent.v4.Job.name] associated with this event.
// For example, if this is an [impression][google.cloud.talent.v4.JobEvent.JobEventType.IMPRESSION] event,
// this field contains the identifiers of all jobs shown to the job seeker.
// If this was a [view][google.cloud.talent.v4.JobEvent.JobEventType.VIEW] event, this field contains the
// identifier of the viewed job.
//
// The format is
// "projects/{project_id}/tenants/{tenant_id}/jobs/{job_id}", for
Expand Down
8 changes: 5 additions & 3 deletions google/cloud/talent_v4/proto/event_service.proto
Expand Up @@ -59,10 +59,12 @@ message CreateClientEventRequest {
// "projects/foo/tenants/bar".
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = { type: "jobs.googleapis.com/Tenant" }
(google.api.resource_reference) = {
type: "jobs.googleapis.com/Tenant"
}
];

// Required. Events issued when end user interacts with customer's application
// that uses Cloud Talent Solution.
// Required. Events issued when end user interacts with customer's application that
// uses Cloud Talent Solution.
ClientEvent client_event = 2 [(google.api.field_behavior) = REQUIRED];
}

0 comments on commit e239d24

Please sign in to comment.