feat(storage): add conformance tests for virtual hosted style signed URLs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
requested changes
Mar 11, 2020
There was a problem hiding this comment.
Thanks @HemangChothani, overall LGTM. One nit on conformance tests.
| "urlStyle": "VIRTUAL_HOSTED_STYLE" | ||
| }, | ||
|
|
||
| { |
There was a problem hiding this comment.
Please keep consistency with https://github.com/googleapis/conformance-tests/blob/master/storage/v1/v4_signatures.json#L232-L244
I don't want to create inconsistencies between main conformance tests and language specific replicas.
frankyn
requested changes
Mar 12, 2020
| { | ||
| "description": "Virtual Hosted Style", | ||
| "bucket": "test-bucket", | ||
| "object": "", |
There was a problem hiding this comment.
Remove this test with empty object. It does not match any in the existing conformance tests.
frankyn
changed the title
frankyn
approved these changes
Mar 12, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…URLs (googleapis#83) * feat(storage): add conformance tests * feat(storage): cover fix * feat(storage): nit * feat(storage): remove unnecessary test
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…URLs (googleapis#83) * feat(storage): add conformance tests * feat(storage): cover fix * feat(storage): nit * feat(storage): remove unnecessary test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10