Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add get notification method #77

Merged
merged 5 commits into from Mar 6, 2020
Merged

feat(storage): add get notification method #77

merged 5 commits into from Mar 6, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #68

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2020
frankyn
frankyn requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I have an ask for an example.

google/cloud/storage/bucket.py
for the server response.

Can also be passed as a tuple (connect_timeout, read_timeout).
See :meth:`requests.Session.request` documentation for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example of how to use this helper method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

frankyn
frankyn approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@frankyn frankyn merged commit f602252 into googleapis:master Mar 6, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @frankyn @cojenco
feat(storage): add get notification method (googleapis#77)
9338a59 
* feat(storage): add get notification method

* feat(storage): address comments

* feat(storage): add an example

* feat(storage): remove an extra blank

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @frankyn @cojenco
feat(storage): add get notification method (googleapis#77)
394a9ac 
* feat(storage): add get notification method

* feat(storage): address comments

* feat(storage): add an example

* feat(storage): remove an extra blank

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Expose the get method of Notifications
3 participants
@HemangChothani @frankyn @googlebot