fix: changeover unspecified to inherited #603

unforced · 2021-09-28T17:42:02Z

Fixes #597 🦕

google/cloud/storage/constants.py

google/cloud/storage/bucket.py

tests/unit/test_bucket.py

Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla · 2021-09-28T18:48:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T18:48:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla · 2021-09-28T18:49:59Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T18:49:59Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

unforced · 2021-09-28T18:58:06Z

@tseaver should I go back and change the commits so I write them rather than just including your suggestions? Or are you able to get the Google/Github CLA thing taken care of from your end?

tseaver · 2021-09-28T19:23:10Z

@googlebot I consent.

google-cla · 2021-09-28T19:23:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tseaver · 2021-09-28T19:26:40Z

@Breathtender As a Googler, you should be able to manually flip the label from cla: no to cla: yes. I don't know why, but the CLA bot sometimes loses its mind about merged suggestions.

…nto pap_change

google-cla · 2021-09-28T19:29:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T22:26:09Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

All changes resolved, and approval was given.

unforced · 2021-09-29T00:56:30Z

Ah, seems we still need a review, after navigating some strange lint issues.

tseaver · 2021-09-29T16:14:01Z

google/cloud/storage/bucket.py

+        """Setting for public access prevention policy. Options are 'inherited' (default) or 'enforced'.
+            See: https://cloud.google.com/storage/docs/public-access-prevention


Still needs the blank line to separate summary from body.

Ah strange, I think the blank line caught the linter, which is why I changed it back. But perhaps I had just left white space in the line which was the issue.

google-cla · 2021-09-29T17:22:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tseaver · 2021-09-29T17:25:52Z

@Breathtender One more manual flip of the CLA flag, and you should be good to go.

* fix: changeover unspecified to inherited * Update google/cloud/storage/bucket.py Co-authored-by: Tres Seaver <tseaver@palladion.com> * Apply suggestions from code review Co-authored-by: Tres Seaver <tseaver@palladion.com> * remove dup line * Apply suggestions from code review Co-authored-by: Tres Seaver <tseaver@palladion.com> * Update tests/unit/test_bucket.py Co-authored-by: cojenco <cathyo@google.com> * lint fix * one more lint fix * line Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: cojenco <cathyo@google.com>

fix: changeover unspecified to inherited

c76dbc6

unforced requested review from shaffeeullah and cojenco September 28, 2021 17:42

unforced requested review from a team as code owners September 28, 2021 17:42

product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 28, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021

tseaver suggested changes Sep 28, 2021

View reviewed changes

Update google/cloud/storage/bucket.py

72f1efa

Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 28, 2021

Apply suggestions from code review

ff03448

Co-authored-by: Tres Seaver <tseaver@palladion.com>

tseaver approved these changes Sep 28, 2021

View reviewed changes

unforced added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2021

Aaron Gabriel Neyer added 2 commits September 28, 2021 13:29

remove dup line

c0f29ea

Merge branch 'pap_change' of github.com:Breathtender/python-storage i…

a2bd5cb

…nto pap_change

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 28, 2021

unforced added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2021

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 28, 2021

cojenco added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2021

one more lint fix

5dc122a

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 28, 2021

unforced added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 29, 2021

tseaver suggested changes Sep 29, 2021

View reviewed changes

line

8127d39

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 29, 2021

tseaver approved these changes Sep 29, 2021

View reviewed changes

unforced added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 29, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021

unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021

unforced merged commit 283a419 into googleapis:main Sep 29, 2021

unforced mentioned this pull request Sep 29, 2021

fix: update samples for pap, unspecified -> inherited GoogleCloudPlatform/python-docs-samples#6757

Merged

release-please bot mentioned this pull request Jan 12, 2022

chore(main): release 3.0.0 #688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: changeover unspecified to inherited #603

fix: changeover unspecified to inherited #603

unforced commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

unforced commented Sep 28, 2021

tseaver commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

tseaver commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

unforced commented Sep 29, 2021

tseaver Sep 29, 2021

unforced Sep 29, 2021

google-cla bot commented Sep 29, 2021

tseaver commented Sep 29, 2021

		"""Setting for public access prevention policy. Options are 'inherited' (default) or 'enforced'.
		See: https://cloud.google.com/storage/docs/public-access-prevention

fix: changeover unspecified to inherited #603

fix: changeover unspecified to inherited #603

Conversation

unforced commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

unforced commented Sep 28, 2021

tseaver commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

tseaver commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

unforced commented Sep 29, 2021

tseaver Sep 29, 2021

Choose a reason for hiding this comment

unforced Sep 29, 2021

Choose a reason for hiding this comment

google-cla bot commented Sep 29, 2021

tseaver commented Sep 29, 2021