feat: generate signed URLs for blobs/buckets using virtual hostname #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
frankyn
requested changes
Feb 13, 2020
google/cloud/storage/blob.py
Outdated
| @@ -361,6 +361,7 @@ def generate_signed_url( | |||
| version=None, | |||
| service_account_email=None, | |||
| access_token=None, | |||
| use_virtual_hostname=False, | |||
There was a problem hiding this comment.
Please use virtual_hosted_style instead.
tseaver
force-pushed
the
10-v4-signing-virtual-hostname
branch
from
5e949f2
to
3be7f6e
Compare
tseaver
force-pushed
the
10-v4-signing-virtual-hostname
branch
from
3be7f6e
to
b75fd1d
Compare
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#58) * Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url' * Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#58) * Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url' * Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.