fix: do not append duplicates to user agent string #570

ddelgrosso1 · 2021-09-01T17:29:49Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #565 🦕

tseaver

@ddelgrosso1 Can you please add a unit test which reproduces the issue (i.e., failing with this change not applied, but passing with it applied)?

google/cloud/storage/_http.py

Move agent_version to a variable Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla · 2021-09-01T18:55:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-01T19:11:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tseaver · 2021-09-01T20:24:32Z

@gooblebot I consent.

tseaver · 2021-09-01T20:27:04Z

@ddelgrosso1 The lint session is failing, likely to do with something in the suggestion you merged. Can you pull from here to your local branch and run nox -s blacken and commit / push the resulting change?

andrewsg · 2021-09-01T21:14:45Z

Denis, please ping me if you would like help running the auto-formatter/linter and writing the regression test.

google-cla · 2021-09-01T21:50:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-01T22:57:21Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-01T23:08:44Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tseaver

@ddelgrosso1 Thanks for the test! I verified that it fails against main without the patch.

🤖 I have created a release \*beep\* \*boop\* --- ### [1.42.1](https://www.github.com/googleapis/python-storage/compare/v1.42.0...v1.42.1) (2021-09-07) ### Bug Fixes * do not append duplicates to user agent string ([#570](https://www.github.com/googleapis/python-storage/issues/570)) ([57cf3a1](https://www.github.com/googleapis/python-storage/commit/57cf3a1f27292939ed097ef8afa3f4392c4b83e0)) ### Documentation * pass explicit 'client' in '{Blob.Bucket}.from_string' examples ([#545](https://www.github.com/googleapis/python-storage/issues/545)) ([6eff22d](https://www.github.com/googleapis/python-storage/commit/6eff22db0e8c8689208ee52fa815f3ea00675094)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis#565 🦕

🤖 I have created a release \*beep\* \*boop\* --- ### [1.42.1](https://www.github.com/googleapis/python-storage/compare/v1.42.0...v1.42.1) (2021-09-07) ### Bug Fixes * do not append duplicates to user agent string ([googleapis#570](https://www.github.com/googleapis/python-storage/issues/570)) ([57cf3a1](https://www.github.com/googleapis/python-storage/commit/57cf3a1f27292939ed097ef8afa3f4392c4b83e0)) ### Documentation * pass explicit 'client' in '{Blob.Bucket}.from_string' examples ([googleapis#545](https://www.github.com/googleapis/python-storage/issues/545)) ([6eff22d](https://www.github.com/googleapis/python-storage/commit/6eff22db0e8c8689208ee52fa815f3ea00675094)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis#565 🦕

🤖 I have created a release \*beep\* \*boop\* --- ### [1.42.1](https://www.github.com/googleapis/python-storage/compare/v1.42.0...v1.42.1) (2021-09-07) ### Bug Fixes * do not append duplicates to user agent string ([googleapis#570](https://www.github.com/googleapis/python-storage/issues/570)) ([57cf3a1](https://www.github.com/googleapis/python-storage/commit/57cf3a1f27292939ed097ef8afa3f4392c4b83e0)) ### Documentation * pass explicit 'client' in '{Blob.Bucket}.from_string' examples ([googleapis#545](https://www.github.com/googleapis/python-storage/issues/545)) ([6eff22d](https://www.github.com/googleapis/python-storage/commit/6eff22db0e8c8689208ee52fa815f3ea00675094)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fix: do not append duplicates to user agent string

5083276

ddelgrosso1 requested a review from a team September 1, 2021 17:29

ddelgrosso1 requested a review from a team as a code owner September 1, 2021 17:29

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021

product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 1, 2021

cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2021

tseaver suggested changes Sep 1, 2021

View reviewed changes

google/cloud/storage/_http.py Outdated Show resolved Hide resolved

Update google/cloud/storage/_http.py

48e6fee

Move agent_version to a variable Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2021

cojenco added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 1, 2021

Merge branch 'main' into user-agent-dupe

cea0b5a

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2021

ddelgrosso1 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 1, 2021

linter fix

5dd1f9d

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2021

ddelgrosso1 added 2 commits September 1, 2021 22:42

Add test for duplicating user agent

762e653

remove hardcoded version

934d0ce

ddelgrosso1 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 1, 2021

fix linter

e65e6c6

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2021

ddelgrosso1 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 2, 2021

tseaver approved these changes Sep 2, 2021

View reviewed changes

Merge branch 'main' into user-agent-dupe

adef243

tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021

gcf-merge-on-green bot merged commit 57cf3a1 into googleapis:main Sep 2, 2021

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021

ddelgrosso1 deleted the user-agent-dupe branch September 2, 2021 17:37

cojenco mentioned this pull request Sep 2, 2021

tests: revise test to run without setting credentials in env #579

Merged

release-please bot mentioned this pull request Jan 12, 2022

chore(main): release 3.0.0 #688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: do not append duplicates to user agent string #570

fix: do not append duplicates to user agent string #570

ddelgrosso1 commented Sep 1, 2021

tseaver left a comment

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

tseaver commented Sep 1, 2021

tseaver commented Sep 1, 2021

andrewsg commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

tseaver left a comment

fix: do not append duplicates to user agent string #570

fix: do not append duplicates to user agent string #570

Conversation

ddelgrosso1 commented Sep 1, 2021

tseaver left a comment

Choose a reason for hiding this comment

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

tseaver commented Sep 1, 2021

tseaver commented Sep 1, 2021

andrewsg commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

google-cla bot commented Sep 1, 2021

tseaver left a comment

Choose a reason for hiding this comment