Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared conformance tests #57

Closed
tseaver opened this issue Feb 12, 2020 · 7 comments
Closed

Update shared conformance tests #57

tseaver opened this issue Feb 12, 2020 · 7 comments
Assignees
Labels
api: storage Issues related to the googleapis/python-storage API. testing type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Feb 12, 2020

We need to add a test suite which exercises the cross-language tests and fix anything where we don't pass.

We need to update the shared conformance tests to match the current spec:

/cc @frankyn

@tseaver tseaver added api: storage Issues related to the googleapis/python-storage API. type: process A process-related concern. May include testing, release, or the like. testing labels Feb 12, 2020
@tseaver tseaver self-assigned this Feb 12, 2020
@frankyn
Copy link
Member

frankyn commented Feb 12, 2020

@tseaver I misunderstood this file -> https://github.com/googleapis/python-storage/blob/master/tests/unit/url_signer_v4_test_data.json

I understood this JSON file as being the cross-language conformance tests.

@tseaver
Copy link
Contributor Author

tseaver commented Feb 12, 2020

Hmmm, looks like that is conformance tests. Dunno how I missed that they existed already. Looks like an older version of the file?

@tseaver tseaver changed the title Add support for shared conformance tests Update shared conformance tests Feb 12, 2020
@frankyn
Copy link
Member

frankyn commented Feb 12, 2020

+1, I recently changed the schema and added conformance tests for Signed Policies.

@tseaver
Copy link
Contributor Author

tseaver commented Feb 12, 2020

Suggested implemenation plan:

  • Move the test drivers for signing out into a separate file, like the test_cross_language.py file in python-firestore.
  • Rename the data file to match the upstream name (v4_signatures.json).
  • Copy in the new test data file, update the test drivers to match the new schema, if needed, and fix anything broken.
  • Add a test driver for the Signed Policy testcases.

@tseaver
Copy link
Contributor Author

tseaver commented Feb 12, 2020

I have a branch which implements the first two steps cleanly, and a stash for the third one, where some of the tests no longer pass. Actually landing the new tests is going to need to wait for PRs #48 and #56 to land, I think.

@frankyn
Copy link
Member

frankyn commented Mar 11, 2020

@HemangChothani, @tseaver is tracking conformance test updates in here. Referenced issues are merged/unblocked.

@frankyn
Copy link
Member

frankyn commented Apr 3, 2020

This was fixed by @IlyaFaer

@frankyn frankyn closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants