Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pass explicit 'client' in '{Blob.Bucket}.from_string' examples #545

Merged
merged 3 commits into from Aug 20, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 19, 2021

See #540.

@tseaver tseaver requested review from cojenco and a team August 19, 2021 18:34
@tseaver tseaver requested a review from a team as a code owner August 19, 2021 18:34
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2021
@tseaver tseaver added the type: docs Improvement to the documentation for an API. label Aug 19, 2021
@tseaver tseaver requested a review from cojenco August 19, 2021 20:09
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the clarification!

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 19, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Aug 20, 2021

Flaky systest is #541.

@tseaver tseaver added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6eff22d into master Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the 540-docs-blob-bucket-from_string-w-client branch August 20, 2021 06:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 8, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants