Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make 'requests.exceptions.ChunkedEncodingError retryable by default #526

Merged
merged 1 commit into from Jul 27, 2021
Merged

fix: make 'requests.exceptions.ChunkedEncodingError retryable by default #526

merged 1 commit into from Jul 27, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 23, 2021

Closes #525.

@tseaver tseaver requested review from tswast and a team July 23, 2021 19:25
@tseaver tseaver requested a review from a team as a code owner July 23, 2021 19:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 23, 2021
@andrewsg
Copy link
Contributor

I think this is googleapis/google-resumable-media-python#240 which can't be solved here in the client library - PR is in the works by @cojenco

@tseaver
Copy link
Contributor Author

tseaver commented Jul 27, 2021

@andrewsg I don't know whether the JSON API (versus the download API) can cause requests to perceive a ChunkedEncodingError -- I do know that the BigQuery API can emit them from JSON API calls (e.g, Client.list_rows(), see googleapis/python-bigquery#801).

andrewsg
andrewsg approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. Sounds like we may need it here too, then.

@tseaver tseaver merged commit 4abb403 into master Jul 27, 2021
@tseaver tseaver deleted the 525-retry-requests-chunked-encoding-error branch July 27, 2021 17:43
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
fix: make 'requests.exceptions.ChunkedEncodingError retryable by defa…
4cf6926 
…ult (googleapis#526)

Closes googleapis#525.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
fix: make 'requests.exceptions.ChunkedEncodingError retryable by defa…
8514a93 
…ult (googleapis#526)

Closes googleapis#525.
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make 'requests.exceptions.ChunkedEncodingError' retryable by default.
2 participants
@tseaver @andrewsg