Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Blob.custom_time' setter doesnt update '_changes' #322

Closed
tamir-jether opened this issue Nov 22, 2020 · 0 comments · Fixed by #323
Closed

'Blob.custom_time' setter doesnt update '_changes' #322

tamir-jether opened this issue Nov 22, 2020 · 0 comments · Fixed by #323
Assignees
@tseaver
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tamir-jether
Copy link

tamir-jether commented Nov 22, 2020 •
edited by tseaver

i think the custom_time setter code should be:

        self._patch_property('customTime', value)

instead of

        self._properties["customTime"] = value
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 22, 2020
haim0n pushed a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
@haimjether
fix: Add change in 'Blob.custom_time' to changes
5e0af3c 
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
@haim0n
fix: Add change in 'Blob.custom_time' to changes
4f1759c 
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@haim0n haim0n mentioned this issue Nov 22, 2020
Merged
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
@haim0n
fix: Add change in 'Blob.custom_time' to changes
ee3533b 
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 23, 2020
@tseaver tseaver added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Nov 24, 2020
@tseaver tseaver self-assigned this Nov 24, 2020
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 24, 2020
@haim0n
fix: Add change in 'Blob.custom_time' to changes
8e36162 
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@tseaver tseaver changed the title custom_time setter doesnt update _changes field 'Blob.custom_time' setter doesnt update '_changes' Nov 24, 2020
tseaver pushed a commit that referenced this issue Nov 24, 2020
@haim0n
fix: update 'custom_time' setter to record change (#323)
5174154 
Closes #322.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@haim0n @cojenco
fix: update 'custom_time' setter to record change (googleapis#323)
0dd2e6b 
Closes googleapis#322.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@haim0n @cojenco
fix: update 'custom_time' setter to record change (googleapis#323)
b2ea59b 
Closes googleapis#322.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add change in 'Blob.custom_time' to changes haim0n/python-storage
3 participants
@tseaver @tamir-jether @yoshi-automation