fix: self-upload files for Unicode system test #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
andrewsg
force-pushed
the
fix-unicode-system-test
branch
from
a1d1954
to
dd6f749
Compare
frankyn
approved these changes
Oct 15, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestUnicode system tests are failing because a public repository of files was deleted. Rather than replace those public files, this PR self-uploads the files as per other tests.
While using a public bucket for this test had some advantages in test fidelity, the brittleness of relying on external static files is a significant problem and this is a compromise solution.