Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add classifiers for python3.9 and remove for python3.5 #295

Merged
merged 9 commits into from Nov 13, 2020
Merged

feat: add classifiers for python3.9 and remove for python3.5 #295

merged 9 commits into from Nov 13, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards #292

  • nox.py file is generated by synthtool, so didn't include changes here.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@HemangChothani HemangChothani linked an issue Oct 15, 2020 that may be closed by this pull request
Add test pass, classifiers for Python 3.9 #292
Closed
@andrewsg
Copy link
Contributor

Will this refuse to install on Python 2.7 or will it just no longer be recommended?

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@tseaver
Copy link
Contributor

tseaver commented Nov 11, 2020

@andrewsg The following will refuse to install on 2.7, at least with any recent setuptools:

    python_requires=">=3.6",

This definitely needs to get merged as a breaking change.

@crwilcox
Copy link
Contributor

I'd recommend waiting to remove Python 2 until other breaking changes. At this time supporting Python 2 isn't providing any drag, but I think once it is we can remove it. @andrewsg @frankyn do we know of any changes that are also breaking to bundle?

tseaver
tseaver reviewed Nov 13, 2020
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@tseaver tseaver changed the title feat: add classifiers for python3.9 and remove for python2.7 and 3.5 feat: add classifiers for python3.9 and remove for python3.5 Nov 13, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
@tseaver tseaver merged commit f072825 into googleapis:master Nov 13, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @frankyn
@tseaver @cojenco
feat: add classifiers for python3.9 and remove for python3.5 (googlea…
69942ca 
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @frankyn
@tseaver @cojenco
feat: add classifiers for python3.9 and remove for python3.5 (googlea…
47d666e 
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test pass, classifiers for Python 3.9
6 participants
@HemangChothani @andrewsg @tseaver @crwilcox @frankyn @yoshi-kokoro