Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test pass, classifiers for Python 3.9 #292

Closed
crwilcox opened this issue Oct 13, 2020 · 1 comment · Fixed by #295
Closed

Add test pass, classifiers for Python 3.9 #292

crwilcox opened this issue Oct 13, 2020 · 1 comment · Fixed by #295
Assignees
@tseaver
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Oct 13, 2020 •
edited

Python 3.9 classifiers and tests should be added.

https://github.com/googleapis/python-storage/blob/master/setup.py#L84
https://github.com/googleapis/python-storage/blob/master/setup.py#L93
https://github.com/googleapis/python-storage/blob/master/noxfile.py#L30
@crwilcox crwilcox added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 13, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 13, 2020
@crwilcox
Copy link
Contributor Author

Similarly, 3.5 should be dropped. it may make sense to drop 2.7 as well.

@HemangChothani HemangChothani mentioned this issue Oct 15, 2020
Merged
@HemangChothani HemangChothani linked a pull request Oct 15, 2020 that will close this issue
feat: add classifiers for python3.9 and remove for python3.5 #295
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add classifiers for python3.9 and remove for python3.5 MaxxleLLC/python-storage
2 participants
@tseaver @crwilcox