Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add requests as a dependency #271

Merged
merged 2 commits into from Sep 16, 2020
Merged

fix: add requests as a dependency #271

merged 2 commits into from Sep 16, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #268

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 15, 2020
@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2020
andrewsg
andrewsg approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to submit this.

@andrewsg
Copy link
Contributor

Build error looks unrelated at first glance, but we need to investigate before merging

@HemangChothani
Copy link
Contributor Author

System test issue will be fixed by PR #273

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@plamut
Copy link
Contributor

plamut commented Sep 16, 2020

Restricting the PubSub version to <2.0.0 indeed helped, system tests now pass again.

@plamut plamut merged commit ec52b38 into googleapis:master Sep 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @plamut @cojenco
fix: add requests as a dependency (googleapis#271)
b1b96e5 
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @plamut @cojenco
fix: add requests as a dependency (googleapis#271)
2cd5ad2 
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requests is missing as dependency
4 participants
@HemangChothani @andrewsg @plamut @yoshi-kokoro