fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

MartinKilonzo · 2020-09-02T20:37:25Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #266 🦕

google/cloud/storage/blob.py

tests/unit/test_blob.py

google-cla · 2020-09-15T19:25:59Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-15T19:51:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-15T21:50:35Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…der' is not provided

google-cla · 2020-09-15T22:38:10Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-15T22:40:59Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-15T22:45:24Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…ehavior. Co-authored-by: Tres Seaver <tseaver@palladion.com>

… header.

google-cla · 2020-09-15T22:55:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-09-15T22:57:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

MartinKilonzo · 2020-09-15T22:59:21Z

Thanks for the review!
Added the proposed changes. @tseaver, would you mind checking your CLA per @googlebot:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tseaver · 2020-09-16T15:59:01Z

@googlebot I fixed it

google-cla · 2020-09-16T16:12:44Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tseaver · 2020-09-16T16:13:04Z

@googlebot I consent

google-cla · 2020-09-16T16:13:14Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-16T16:13:23Z

☹️ Sorry, but only Googlers may change the label cla: yes.

tseaver · 2020-09-16T17:13:03Z

@MartinKilonzo Thanks for persevering!

…resent (googleapis#267) Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2020

MartinKilonzo changed the title ~~Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present~~ fix(blob.py): Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present Sep 2, 2020

MartinKilonzo force-pushed the master branch from 5c10477 to 8b4ca5d Compare September 2, 2020 21:02

MartinKilonzo mentioned this pull request Sep 2, 2020

Hashes are no longer returned for partial downloads #266

Closed

product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 3, 2020

tseaver reviewed Sep 14, 2020

View reviewed changes

google/cloud/storage/blob.py Outdated Show resolved Hide resolved

tests/unit/test_blob.py Show resolved Hide resolved

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 15, 2020

fix(blob.py): returns blob hashes (md5, crc32c) when 'X-Goog-Hash hea…

4d3faad

…der' is not provided

MartinKilonzo force-pushed the master branch from 068314c to 7d2d295 Compare September 15, 2020 22:38

MartinKilonzo force-pushed the master branch from 7d2d295 to 8ee1c53 Compare September 15, 2020 22:40

MartinKilonzo force-pushed the master branch from 8ee1c53 to 2926d55 Compare September 15, 2020 22:45

remmykilonzo and others added 2 commits September 15, 2020 22:55

Renaming tests for downloads with missing headers to better reflect b…

6250fcf

…ehavior. Co-authored-by: Tres Seaver <tseaver@palladion.com>

Only set CRC32C and MD5 hashes if they are present in the X-Goog-Hash…

2e4f4dd

… header.

MartinKilonzo force-pushed the master branch from 2926d55 to 2e4f4dd Compare September 15, 2020 22:55

Merge branch 'master' into master

5f3586f

Merge branch 'master' into master

1b630d0

google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 16, 2020

tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 16, 2020

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020

tseaver approved these changes Sep 16, 2020

View reviewed changes

tseaver changed the title ~~fix(blob.py): Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present~~ fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present Sep 16, 2020

tseaver merged commit 277afb8 into googleapis:master Sep 16, 2020

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not p…

834c477

…resent (googleapis#267) Co-authored-by: Tres Seaver <tseaver@palladion.com>

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not p…

6d0e6ab

…resent (googleapis#267) Co-authored-by: Tres Seaver <tseaver@palladion.com>

release-please bot mentioned this pull request Jan 12, 2022

chore(main): release 3.0.0 #688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

MartinKilonzo commented Sep 2, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

googlebot commented Sep 15, 2020

MartinKilonzo commented Sep 15, 2020

tseaver commented Sep 16, 2020 •

edited

google-cla bot commented Sep 16, 2020

tseaver commented Sep 16, 2020

google-cla bot commented Sep 16, 2020

google-cla bot commented Sep 16, 2020

tseaver commented Sep 16, 2020

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

Conversation

MartinKilonzo commented Sep 2, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

google-cla bot commented Sep 15, 2020

googlebot commented Sep 15, 2020

MartinKilonzo commented Sep 15, 2020

tseaver commented Sep 16, 2020 • edited

google-cla bot commented Sep 16, 2020

tseaver commented Sep 16, 2020

google-cla bot commented Sep 16, 2020

google-cla bot commented Sep 16, 2020

tseaver commented Sep 16, 2020

tseaver commented Sep 16, 2020 •

edited