Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python #25

Open
crwilcox opened this issue Oct 28, 2019 · 4 comments
Open

Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python #25

crwilcox opened this issue Oct 28, 2019 · 4 comments
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: cleanup An internal cleanup or hygiene concern.

Comments

@crwilcox
Copy link
Contributor

internal bug: b/143493862

The Python Client has a patch googleapis/google-cloud-python#9548 to temporarily collect metrics until we address a pipeline issue. This is a temporary fix and should be removed once that is done.
@tseaver tseaver changed the title Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python Storage, Core: Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python Oct 29, 2019
@crwilcox crwilcox transferred this issue from googleapis/google-cloud-python Jan 31, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 3, 2020
@frankyn frankyn added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. status: blocked Resolving the issue is dependent on other work. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 17, 2020

@frankyn Do we still need to preserve the gcloud-python header?

@tseaver tseaver changed the title Storage, Core: Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python Once x-goog-api-client headers, gccl, is used for storage, remove gcloud-python Aug 17, 2020
@frankyn
Copy link
Member

frankyn commented Aug 24, 2020

As far as I'm aware yes. @jsimonweb do you know if we are tracking the correct headers now?

@tseaver
Copy link
Contributor

tseaver commented May 24, 2021

@frankyn, @crwilcox, @jsimonweb Bumping to check on this one again: should we be removing the gcloud-python header (i.e., revert dc817e9)?

tseaver added a commit that referenced this issue May 24, 2021
@tseaver
Revert "fix: add gcloud-python header to user agent (#9551)"
2ae94d9 
This reverts commit dc817e9.

Closes #25.
@tseaver tseaver mentioned this issue May 24, 2021
Closed
@frankyn
Copy link
Member

frankyn commented Jun 1, 2021

Not yet. Let's close out the PR for now so it doesn't become stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: drop gcloud-python header from user agent googleapis/python-storage
4 participants
@tseaver @crwilcox @frankyn @yoshi-automation