Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract hashes correctly during download #238

Merged
merged 8 commits into from Aug 14, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #237 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2020
google/cloud/storage/blob.py Outdated Show resolved Hide resolved
tests/unit/test_blob.py Show resolved Hide resolved
google/cloud/storage/blob.py Outdated Show resolved Hide resolved
@tseaver tseaver changed the title fix: multiple upload and download fix: extract hashes correctly during download Aug 13, 2020
@tseaver tseaver dismissed frankyn’s stale review August 13, 2020 19:42

changes applied

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 14, 2020
@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@tseaver tseaver merged commit 23cfb65 into googleapis:master Aug 14, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple upload and downloads fail
4 participants