Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass 'client_options' to base class ctor #225

Merged

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 4, 2020

packaging: pin 'google-cloud-core >= 1.4.0'

Closes #210

packaging: pin 'google-cloud-core >= 1.4.0'

Closes #210
@tseaver tseaver requested a review from busunkim96 August 4, 2020 20:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit e1f91fc into master Aug 5, 2020
@tseaver tseaver deleted the 210-pass-client_options-to-baseclass-ctor branch August 5, 2020 03:22
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new client options
2 participants